Misc cleanups of generic_arg_infer related HIR logic
#142678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
BoxyUwU
changed the title
generic_arg_infer related logicgeneric_arg_infer related HIR logic
fmease
reviewed
Jun 18, 2025
This comment has been minimized.
This comment has been minimized.
nnethercote
reviewed
Jun 19, 2025
| // SAFETY: `repr(u8)` is required so that `TyKind<()>` and `TyKind<!>` are layout compatible | ||
| #[repr(u8, C)] | ||
| #[derive(Debug, Clone, Copy, HashStable_Generic)] |
There was a problem hiding this comment.
Why these new derives?
There was a problem hiding this comment.
not new I just moved them below all the comments
|
Apologies, this review slipped through the cracks! Looks ok. @bors r+ |
bors
added
S-waiting-on-bors
|
No worries, this wasn't blocking anything :) |
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 3, 2025
Misc cleanups of `generic_arg_infer` related HIR logic r? `@nnethercote`
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 3, 2025
Misc cleanups of `generic_arg_infer` related HIR logic r? ``@nnethercote``
bors
added a commit
that referenced
this pull request
Aug 3, 2025
Rollup of 11 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144650 (Additional tce tests) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) Failed merges: - #144794 (Port `#[coroutine]` to the new attribute system) r? `@ghost` `@rustbot` modify labels: rollup
samueltardieu
added a commit
to samueltardieu/rust
that referenced
this pull request
Aug 3, 2025
Misc cleanups of `generic_arg_infer` related HIR logic r? ```@nnethercote```
This was referenced Aug 3, 2025
bors
added a commit
that referenced
this pull request
Aug 3, 2025
Rollup of 12 pull requests Successful merges: - #142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - #144070 (Implement `hash_map` macro ) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144790 (Multiple bounds checking elision failures) - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - #144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - #144816 (Update E0562 to account for the new impl trait positions) - #144822 (Return a struct with named fields from `hash_owner_nodes`) - #144824 (Updated test links in compiler) - #144829 (Use full flag name in strip command for Darwin) - #144843 (Weekly `cargo update`) - #144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 4, 2025
Rollup merge of #142678 - BoxyUwU:gai_cleanup, r=nnethercote Misc cleanups of `generic_arg_infer` related HIR logic r? ````@nnethercote````
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 4, 2025
Rollup of 12 pull requests Successful merges: - rust-lang/rust#142678 (Misc cleanups of `generic_arg_infer` related HIR logic) - rust-lang/rust#144070 (Implement `hash_map` macro ) - rust-lang/rust#144738 (Remove the omit_gdb_pretty_printer_section attribute) - rust-lang/rust#144790 (Multiple bounds checking elision failures) - rust-lang/rust#144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) - rust-lang/rust#144808 (`Interner` arg to `EarlyBinder` does not affect auto traits) - rust-lang/rust#144816 (Update E0562 to account for the new impl trait positions) - rust-lang/rust#144822 (Return a struct with named fields from `hash_owner_nodes`) - rust-lang/rust#144824 (Updated test links in compiler) - rust-lang/rust#144829 (Use full flag name in strip command for Darwin) - rust-lang/rust#144843 (Weekly `cargo update`) - rust-lang/rust#144851 (Forbid tail calling intrinsics) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nnethercote