Skip to content

fix: correct assertion to check for 'noinline' attribute presence before removal #143633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

fix: correct assertion to check for 'noinline' attribute presence before removal #143633

merged 1 commit into from
Jul 12, 2025

Conversation

dillona
Copy link
Contributor

@dillona dillona commented Jul 8, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 8, 2025
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 11, 2025

📌 Commit b2299e2 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025
@fee1-dead
Copy link
Member

If possible, please add a test to exercise this code path

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 11, 2025
@matthiaskrgr
Rollup merge of rust-lang#143633 - dillona:noinline-assert, r=fee1-dead
e932509 
fix: correct assertion to check for 'noinline' attribute presence before removal
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 11, 2025
Closed
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143790 - matthiaskrgr:rollup-hslb9jq, r=matthiaskrgr
5e942ad 
Rollup of 10 pull requests

Successful merges:

 - #142301 (tests: Fix duplicated-path-in-error fail with musl)
 - #143403 (Port several trait/coherence-related attributes the new attribute system)
 - #143633 (fix: correct assertion to check for 'noinline' attribute presence before removal)
 - #143647 (Clarify and expand documentation for std::sys_common dependency structure)
 - #143716 (compiler: doc/comment some codegen-for-functions interfaces)
 - #143747 (Add target maintainer information for aarch64-unknown-linux-musl)
 - #143759 (Fix typos in function names in the `target_feature` test)
 - #143767 (Bump `src/tools/x` to Edition 2024 and some cleanups)
 - #143769 (Remove support for SwitchInt edge effects in backward dataflow)
 - #143770 (build-helper: clippy fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 11, 2025
Merged
bors added a commit that referenced this pull request Jul 12, 2025
@bors
Auto merge of #143810 - matthiaskrgr:rollup-iw7a23z, r=matthiaskrgr
915e535 
Rollup of 9 pull requests

Successful merges:

 - #143403 (Port several trait/coherence-related attributes the new attribute system)
 - #143633 (fix: correct assertion to check for 'noinline' attribute presence before removal)
 - #143647 (Clarify and expand documentation for std::sys_common dependency structure)
 - #143716 (compiler: doc/comment some codegen-for-functions interfaces)
 - #143747 (Add target maintainer information for aarch64-unknown-linux-musl)
 - #143759 (Fix typos in function names in the `target_feature` test)
 - #143767 (Bump `src/tools/x` to Edition 2024 and some cleanups)
 - #143769 (Remove support for SwitchInt edge effects in backward dataflow)
 - #143770 (build-helper: clippy fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7f3204f into rust-lang:master Jul 12, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 12, 2025
rust-timer added a commit that referenced this pull request Jul 12, 2025
@rust-timer
Unrolled build for #143633
8659a1c 
Rollup merge of #143633 - dillona:noinline-assert, r=fee1-dead

fix: correct assertion to check for 'noinline' attribute presence before removal
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 15, 2025
@bors
Auto merge of #143810 - matthiaskrgr:rollup-iw7a23z, r=matthiaskrgr
d51d10b 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#143403 (Port several trait/coherence-related attributes the new attribute system)
 - rust-lang/rust#143633 (fix: correct assertion to check for 'noinline' attribute presence before removal)
 - rust-lang/rust#143647 (Clarify and expand documentation for std::sys_common dependency structure)
 - rust-lang/rust#143716 (compiler: doc/comment some codegen-for-functions interfaces)
 - rust-lang/rust#143747 (Add target maintainer information for aarch64-unknown-linux-musl)
 - rust-lang/rust#143759 (Fix typos in function names in the `target_feature` test)
 - rust-lang/rust#143767 (Bump `src/tools/x` to Edition 2024 and some cleanups)
 - rust-lang/rust#143769 (Remove support for SwitchInt edge effects in backward dataflow)
 - rust-lang/rust#143770 (build-helper: clippy fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
@SabrinaJewson SabrinaJewson mentioned this pull request Jul 16, 2025
Open
@dillona dillona deleted the noinline-assert branch July 16, 2025 14:31
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 21, 2025
@bors
Auto merge of rust-lang#143810 - matthiaskrgr:rollup-iw7a23z, r=matth…
bdbb84d 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#143403 (Port several trait/coherence-related attributes the new attribute system)
 - rust-lang#143633 (fix: correct assertion to check for 'noinline' attribute presence before removal)
 - rust-lang#143647 (Clarify and expand documentation for std::sys_common dependency structure)
 - rust-lang#143716 (compiler: doc/comment some codegen-for-functions interfaces)
 - rust-lang#143747 (Add target maintainer information for aarch64-unknown-linux-musl)
 - rust-lang#143759 (Fix typos in function names in the `target_feature` test)
 - rust-lang#143767 (Bump `src/tools/x` to Edition 2024 and some cleanups)
 - rust-lang#143769 (Remove support for SwitchInt edge effects in backward dataflow)
 - rust-lang#143770 (build-helper: clippy fixes)

r? `@ghost`
`@rustbot` modify labels: rollup
@ZuseZ4
Copy link
Member

ZuseZ4 commented Jul 22, 2025

@fee1-dead This actually had a test, which started failing after this pr, as e.g. reported here: #wg-autodiff > Expected __enzyme function to have 'noinline' before adding @ 💬
Unfortunately we don't enable autodiff in CI yet since it increases the binary size by 9MiB, I hope to either receive approval for that or someone to land a workaround in the near future. My assumption is that the has_attr function might be returning the opposite result, which was cancelled out by the !. One of the gsoc projects simplifies the whole logic, so we can probably drop it and the llvm wrapper once it's land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dillona @rustbot @fee1-dead @bors @ZuseZ4