[rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. #143662

obi1kenobi · 2025-07-09T00:50:43Z

Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML:

#[no_mangle] -> #[unsafe(no_mangle)]
#[export_name = "foo"] -> #[unsafe(export_name = "foo")]
#[link_section = ".text"] -> #[unsafe(link_section = ".text")]

The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that unsafe() wasn't always necessary) in order to understand a crate's documentation.

After some looking through the T-rustdoc issues, I was not able to find an existing issue for this. Apologies if I missed it.

r? @aDotInTheVoid

rustbot · 2025-07-09T00:50:47Z

aDotInTheVoid is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-07-09T00:50:49Z

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

It's intentional.
The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

aDotInTheVoid · 2025-07-09T01:35:27Z

#142936 is likely to merge before this, as this requires a FCP for UI changes. Therefore all the rustdoc-json changes are likely to go away here.

@rfcbot fcp merge

obi1kenobi · 2025-07-09T01:37:24Z

Not an issue, thanks for the heads-up.

aDotInTheVoid · 2025-07-09T01:39:19Z

@rfcbot fcp cancel

rfcbot · 2025-07-09T01:39:20Z

@aDotInTheVoid proposal cancelled.

aDotInTheVoid · 2025-07-09T01:40:34Z

@rfcbot fcp merge

(accidentally FCP’d to full T-Rustdoc, not T-Rustdoc-Frontend 💀)

aDotInTheVoid · 2025-07-09T07:35:23Z

@rust-lang/rustdoc-frontend can someone start an FCP on this?

GuillaumeGomez · 2025-07-09T08:13:31Z

Sounds like a good idea!

@aDotInTheVoid normally with only the t-rustdoc-frontend tag, you were good to go. 😉

EDIT: Ah no, just learned that you need o be part of the (sub-)team to do that, my bad.

@rfcbot fcp merge

rfcbot · 2025-07-09T08:13:34Z

Team member @GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2025-07-21T23:23:13Z

🔔 This is now entering its final comment period, as per the review above. 🔔

obi1kenobi · 2025-07-23T12:34:35Z

No worries, I'm familiar. I just wanted to describe the changes that happened and mention that I cleared out the dozen merge conflicts successfully :)

rfcbot · 2025-07-31T23:27:48Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

GuillaumeGomez · 2025-08-01T08:55:15Z

Thanks everyone!

@bors r=t-rustdoc rollup

bors · 2025-08-01T08:55:17Z

📌 Commit 45231fa has been approved by t-rustdoc

It is now in the queue for this repository.

…ppers, r=t-rustdoc [rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML: - `#[no_mangle]` -> `#[unsafe(no_mangle)]` - `#[export_name = "foo"]` -> `#[unsafe(export_name = "foo")]` - `#[link_section = ".text"]` -> `#[unsafe(link_section = ".text")]` The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that `unsafe()` wasn't always necessary) in order to understand a crate's documentation. After some looking through the `T-rustdoc` issues, I was not able to find an existing issue for this. Apologies if I missed it. r? `@aDotInTheVoid`

Rollup of 10 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144738 (Remove the omit_gdb_pretty_printer_section attribute) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") r? `@ghost` `@rustbot` modify labels: rollup

…ppers, r=t-rustdoc [rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML: - `#[no_mangle]` -> `#[unsafe(no_mangle)]` - `#[export_name = "foo"]` -> `#[unsafe(export_name = "foo")]` - `#[link_section = ".text"]` -> `#[unsafe(link_section = ".text")]` The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that `unsafe()` wasn't always necessary) in order to understand a crate's documentation. After some looking through the `T-rustdoc` issues, I was not able to find an existing issue for this. Apologies if I missed it. r? ``@aDotInTheVoid``

Rollup of 11 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144478 (Improve formatting of doc code blocks) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) r? `@ghost` `@rustbot` modify labels: rollup

…ppers, r=t-rustdoc [rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML: - `#[no_mangle]` -> `#[unsafe(no_mangle)]` - `#[export_name = "foo"]` -> `#[unsafe(export_name = "foo")]` - `#[link_section = ".text"]` -> `#[unsafe(link_section = ".text")]` The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that `unsafe()` wasn't always necessary) in order to understand a crate's documentation. After some looking through the `T-rustdoc` issues, I was not able to find an existing issue for this. Apologies if I missed it. r? ```@aDotInTheVoid```

…ppers, r=t-rustdoc [rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML: - `#[no_mangle]` -> `#[unsafe(no_mangle)]` - `#[export_name = "foo"]` -> `#[unsafe(export_name = "foo")]` - `#[link_section = ".text"]` -> `#[unsafe(link_section = ".text")]` The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that `unsafe()` wasn't always necessary) in order to understand a crate's documentation. After some looking through the `T-rustdoc` issues, I was not able to find an existing issue for this. Apologies if I missed it. r? ````@aDotInTheVoid````

Rollup of 12 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #144478 (Improve formatting of doc code blocks) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - #144786 (Cleanup the definition of `group_type`) - #144796 (Add my previous commit name to .mailmap) - #144797 (Update safety comment for new_unchecked in niche_types) r? `@ghost` `@rustbot` modify labels: rollup

…ppers, r=t-rustdoc [rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML: - `#[no_mangle]` -> `#[unsafe(no_mangle)]` - `#[export_name = "foo"]` -> `#[unsafe(export_name = "foo")]` - `#[link_section = ".text"]` -> `#[unsafe(link_section = ".text")]` The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that `unsafe()` wasn't always necessary) in order to understand a crate's documentation. After some looking through the `T-rustdoc` issues, I was not able to find an existing issue for this. Apologies if I missed it. r? `````@aDotInTheVoid`````

Rollup of 18 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #135771 ([rustdoc] Add support for associated items in "jump to def" feature) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143771 (Constify some more `Result` functions) - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144185 (Document guarantees of poisoning) - #144395 (update fortanix tests) - #144478 (Improve formatting of doc code blocks) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - #144786 (Cleanup the definition of `group_type`) - #144796 (Add my previous commit name to .mailmap) - #144797 (Update safety comment for new_unchecked in niche_types) Failed merges: - #144805 (compiletest: Preliminary cleanup of `ProcRes` printing/unwinding) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - #143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - #143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - #143771 (Constify some more `Result` functions) - #144185 (Document guarantees of poisoning) - #144395 (update fortanix tests) - #144478 (Improve formatting of doc code blocks) - #144614 (Fortify RemoveUnneededDrops test.) - #144703 ([test][AIX] ignore extern_weak linkage test) - #144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - #144756 (detect infinite recursion with tail calls in ctfe) - #144766 (Add human readable name "Cygwin") - #144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - #144786 (Cleanup the definition of `group_type`) - #144796 (Add my previous commit name to .mailmap) - #144797 (Update safety comment for new_unchecked in niche_types) - #144803 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143662 - obi1kenobi:pg/unsafe-attribute-wrappers, r=t-rustdoc [rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. Use Rust 2024 edition representation for unsafe attributes in rustdoc HTML: - `#[no_mangle]` -> `#[unsafe(no_mangle)]` - `#[export_name = "foo"]` -> `#[unsafe(export_name = "foo")]` - `#[link_section = ".text"]` -> `#[unsafe(link_section = ".text")]` The 2024 edition representation is used regardless of the crate's own edition. This ensures that Rustaceans don't have to learn the rules of an outdated edition (e.g. that `unsafe()` wasn't always necessary) in order to understand a crate's documentation. After some looking through the `T-rustdoc` issues, I was not able to find an existing issue for this. Apologies if I missed it. r? ``````@aDotInTheVoid``````

Rollup of 17 pull requests Successful merges: - rust-lang/rust#132748 (get rid of some false negatives in rustdoc::broken_intra_doc_links) - rust-lang/rust#143360 (loop match: error on `#[const_continue]` outside `#[loop_match]`) - rust-lang/rust#143662 ([rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers.) - rust-lang/rust#143771 (Constify some more `Result` functions) - rust-lang/rust#144185 (Document guarantees of poisoning) - rust-lang/rust#144395 (update fortanix tests) - rust-lang/rust#144478 (Improve formatting of doc code blocks) - rust-lang/rust#144614 (Fortify RemoveUnneededDrops test.) - rust-lang/rust#144703 ([test][AIX] ignore extern_weak linkage test) - rust-lang/rust#144747 (compiletest: Improve diagnostics for line annotation mismatches 2) - rust-lang/rust#144756 (detect infinite recursion with tail calls in ctfe) - rust-lang/rust#144766 (Add human readable name "Cygwin") - rust-lang/rust#144782 (Properly pass path to staged `rustc` to `compiletest` self-tests) - rust-lang/rust#144786 (Cleanup the definition of `group_type`) - rust-lang/rust#144796 (Add my previous commit name to .mailmap) - rust-lang/rust#144797 (Update safety comment for new_unchecked in niche_types) - rust-lang/rust#144803 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned aDotInTheVoid Jul 9, 2025

rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 9, 2025

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jul 9, 2025

obi1kenobi mentioned this pull request Jul 9, 2025

rustdoc-json: Structured attributes #142936

Merged

4 tasks

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025

rust-lang deleted a comment from rfcbot Jul 9, 2025

rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025

aDotInTheVoid removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 9, 2025

GuillaumeGomez approved these changes Jul 9, 2025

View reviewed changes

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025

lolbinarycat approved these changes Jul 9, 2025

View reviewed changes

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jul 21, 2025

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 21, 2025

obi1kenobi force-pushed the pg/unsafe-attribute-wrappers branch from d265073 to a24afdb Compare July 22, 2025 23:01

rustbot mentioned this pull request Jul 31, 2025

Tracking issue for release notes of #143662: [rustdoc] Display unsafe attrs with edition 2024 unsafe() wrappers. #144760

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025

GuillaumeGomez mentioned this pull request Aug 1, 2025

Rollup of 10 pull requests #144784

Closed

GuillaumeGomez mentioned this pull request Aug 1, 2025

Rollup of 11 pull requests #144791

Closed

GuillaumeGomez mentioned this pull request Aug 1, 2025

Rollup of 12 pull requests #144799

Closed

samueltardieu mentioned this pull request Aug 2, 2025

Rollup of 18 pull requests #144810

Closed

samueltardieu mentioned this pull request Aug 2, 2025

Rollup of 17 pull requests #144814

Merged

aDotInTheVoid removed the to-announce Announce this issue on triage meeting label Aug 2, 2025

bors merged commit 4eddebd into rust-lang:master Aug 3, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Aug 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. #143662

[rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. #143662

obi1kenobi commented Jul 9, 2025 •

edited

Loading

Uh oh!

rustbot commented Jul 9, 2025

Uh oh!

rustbot commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025 •

edited

Loading

Uh oh!

obi1kenobi commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025

Uh oh!

rfcbot commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025

Uh oh!

GuillaumeGomez commented Jul 9, 2025 •

edited

Loading

Uh oh!

rfcbot commented Jul 9, 2025 •

edited by jsha

Loading

Uh oh!

rfcbot commented Jul 21, 2025

Uh oh!

obi1kenobi commented Jul 23, 2025

Uh oh!

rfcbot commented Jul 31, 2025

Uh oh!

GuillaumeGomez commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

[rustdoc] Display unsafe attrs with edition 2024 unsafe() wrappers. #143662

[rustdoc] Display unsafe attrs with edition 2024 unsafe() wrappers. #143662

Conversation

obi1kenobi commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 9, 2025

Uh oh!

rustbot commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

obi1kenobi commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025

Uh oh!

rfcbot commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025

Uh oh!

aDotInTheVoid commented Jul 9, 2025

Uh oh!

GuillaumeGomez commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jul 9, 2025 • edited by jsha Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jul 21, 2025

Uh oh!

obi1kenobi commented Jul 23, 2025

Uh oh!

rfcbot commented Jul 31, 2025

Uh oh!

GuillaumeGomez commented Aug 1, 2025

Uh oh!

bors commented Aug 1, 2025

Uh oh!

Uh oh!

Uh oh!

[rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. #143662

[rustdoc] Display unsafe attrs with edition 2024 `unsafe()` wrappers. #143662

obi1kenobi commented Jul 9, 2025 •

edited

Loading

aDotInTheVoid commented Jul 9, 2025 •

edited

Loading

GuillaumeGomez commented Jul 9, 2025 •

edited

Loading

rfcbot commented Jul 9, 2025 •

edited by jsha

Loading