Skip to content

Change memcmp and bcmp return type to c_int #144141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

supersurviveur
Copy link
Contributor

@supersurviveur supersurviveur commented Jul 18, 2025

This PR fix the return type of memcmp builtin function on target with a pointer_width equals to 16.
Linked issue: #144076

@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

compiler-builtins is developed in its own repository. If possible, consider making this change to rust-lang/compiler-builtins instead.

cc @tgross35

@tgross35
Copy link
Contributor

tgross35 commented Jul 18, 2025

^ Yeah could you please make a PR to the subtree at https://github.com/rust-lang/compiler-builtins instead? We don't run the full test suite in rust-lang/rust

@supersurviveur
Copy link
Contributor Author

Closed in favor of rust-lang/compiler-builtins#980

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants