std: sys: io: io_slice: Add UEFI types #144350
Open
+196
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Ayush1325
force-pushed
the
uefi-io
branch
2 times, most recently
from
5ee308f to
17cd61d
Compare
| // that `IoSlice` and `IoSliceMut` are compatible with the vectored types for all the | ||
| // networking protocols. | ||
|
|
||
| fn to_slice<T>(val: &T) -> &[u8] { |
There was a problem hiding this comment.
Even though this is just test code, the function is unsafe and should be marked as such.
| #[inline] | ||
| pub fn advance(&mut self, n: usize) { | ||
| let count: u32 = n.try_into().unwrap(); | ||
| self.len += count; |
There was a problem hiding this comment.
Shouldn't this be subtracting, not adding?
A couple other notes: I think this should use checked arithmetic since advance is supposed to panic "when trying to advance beyond the end of the slice". Also the Unix and Windows impls also have a nice "advancing IoSlice beyond its length" panic message which would be good to include here.
Something like:
self.len = u32::try_from(n)
.ok()
.and_then(|n| self.len.checked_sub(n))
.expect("advancing IoSlice beyond its length");(Ditto for the mut advance impl)
| ]; | ||
|
|
||
| assert_eq!(to_slice(&lhs), to_slice(&rhs)); | ||
| } |
There was a problem hiding this comment.
Would be good to add a test or two for advance/as_slice/into_slice/as_mut_slice
UEFI networking APIs do support vectored read/write. While the types for UDP4, UDP6, TCP4 and TCP6 are defined separately, they are essentially the same C struct. So we can map IoSlice and IoSliceMut to have the same binary representation. Since all UEFI networking types for read/write are DSTs, `IoSlice` and `IoSliceMut` will need to be copied to the end of the transmit/receive structures. So having the same binary representation just allows us to do a single memcpy instead of having to loop and set the DST. Signed-off-by: Ayush Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UEFI networking APIs do support vectored read/write. While the types for UDP4, UDP6, TCP4 and TCP6 are defined separately, they are essentially the same C struct. So we can map IoSlice and IoSliceMut to have the same binary representation.
Since all UEFI networking types for read/write are DSTs,
IoSliceandIoSliceMutwill need to be copied to the end of the transmit/receive structures. So having the same binary representation just allows us to do a single memcpy instead of having to loop and set the DST.cc @nicholasbishop