Skip to content

rustc_public: Remove movability from RigidTy/AggregateKind::Coroutine #144392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

rustc_public: Remove movability from RigidTy/AggregateKind::Coroutine #144392

merged 1 commit into from
Jul 25, 2025

Conversation

makai410
Copy link
Contributor

@makai410 makai410 commented Jul 24, 2025 •
edited
Loading

Part of #119174 .
I think we should be good now to sync this change in rustc_public.

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@scottmcm
Copy link
Member

Looks good to me. Always nice to see FIXMEs fixed :)

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 24, 2025

📌 Commit 642deb3 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2025
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#144392 - makai410:rm-mov, r=scottmcm
f68aaab 
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`

Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
@fmease fmease mentioned this pull request Jul 24, 2025
Closed
bors added a commit that referenced this pull request Jul 24, 2025
@bors
Auto merge of #144418 - fmease:rollup-qgs9q1t, r=fmease
d0a74e1 
Rollup of 16 pull requests

Successful merges:

 - #142569 (Suggest clone in user-write-code instead of inside macro)
 - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
 - #143424 (clippy fix: rely on autoderef)
 - #143970 (Update core::mem::copy documentation)
 - #143979 (Test fixes for Arm64EC Windows)
 - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc)
 - #144200 (Tweak output for non-`Clone` values moved into closures)
 - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
 - #144225 (Don't special-case llvm.* as nounwind)
 - #144314 (Hint that choose_pivot returns index in bounds)
 - #144316 (bootstrap: Move musl-root fallback out of sanity check)
 - #144364 (Update `dlmalloc` dependency of libstd)
 - #144368 (resolve: Remove `Scope::CrateRoot`)
 - #144373 (remove deprecated Error::description in impls)
 - #144390 (Remove dead code and extend test coverage and diagnostics around it)
 - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)

r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Jul 25, 2025
@fmease
Rollup merge of rust-lang#144392 - makai410:rm-mov, r=scottmcm
c009bc0 
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`

Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
@fmease fmease mentioned this pull request Jul 25, 2025
Closed
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144428 - fmease:rollup-ufg2p55, r=fmease
7921df0 
Rollup of 17 pull requests

Successful merges:

 - #142569 (Suggest clone in user-write-code instead of inside macro)
 - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
 - #143424 (clippy fix: rely on autoderef)
 - #143970 (Update core::mem::copy documentation)
 - #143979 (Test fixes for Arm64EC Windows)
 - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc)
 - #144200 (Tweak output for non-`Clone` values moved into closures)
 - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
 - #144225 (Don't special-case llvm.* as nounwind)
 - #144314 (Hint that choose_pivot returns index in bounds)
 - #144316 (bootstrap: Move musl-root fallback out of sanity check)
 - #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
 - #144364 (Update `dlmalloc` dependency of libstd)
 - #144368 (resolve: Remove `Scope::CrateRoot`)
 - #144390 (Remove dead code and extend test coverage and diagnostics around it)
 - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
 - #144424 (Allow setting `release-blog-post` label with rustbot)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 25, 2025
@matthiaskrgr
Rollup merge of rust-lang#144392 - makai410:rm-mov, r=scottmcm
ac8745e 
rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`

Part of rust-lang#119174 .
I think we should be good now to sync this change in rustc_public.
This was referenced Jul 25, 2025
Closed
Merged
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144436 - matthiaskrgr:rollup-3cmdjgf, r=
7ea4922 
Rollup of 16 pull requests

Successful merges:

 - #142569 (Suggest clone in user-write-code instead of inside macro)
 - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
 - #143424 (clippy fix: rely on autoderef)
 - #143970 (Update core::mem::copy documentation)
 - #143979 (Test fixes for Arm64EC Windows)
 - #144160 (tests: debuginfo: Work around or disable broken tests on powerpc)
 - #144200 (Tweak output for non-`Clone` values moved into closures)
 - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
 - #144314 (Hint that choose_pivot returns index in bounds)
 - #144316 (bootstrap: Move musl-root fallback out of sanity check)
 - #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
 - #144364 (Update `dlmalloc` dependency of libstd)
 - #144368 (resolve: Remove `Scope::CrateRoot`)
 - #144390 (Remove dead code and extend test coverage and diagnostics around it)
 - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)
 - #144424 (Allow setting `release-blog-post` label with rustbot)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jul 25, 2025
@bors
Auto merge of #144440 - matthiaskrgr:rollup-peb88gb, r=matthiaskrgr
a955f1c 
Rollup of 12 pull requests

Successful merges:

 - #142569 (Suggest clone in user-write-code instead of inside macro)
 - #143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
 - #143424 (clippy fix: rely on autoderef)
 - #143970 (Update core::mem::copy documentation)
 - #143979 (Test fixes for Arm64EC Windows)
 - #144200 (Tweak output for non-`Clone` values moved into closures)
 - #144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
 - #144314 (Hint that choose_pivot returns index in bounds)
 - #144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
 - #144368 (resolve: Remove `Scope::CrateRoot`)
 - #144390 (Remove dead code and extend test coverage and diagnostics around it)
 - #144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1caf701 into rust-lang:master Jul 25, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jul 25, 2025
@rust-timer
Unrolled build for #144392
fb41a7e 
Rollup merge of #144392 - makai410:rm-mov, r=scottmcm

rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`

Part of #119174 .
I think we should be good now to sync this change in rustc_public.
@rustbot rustbot added this to the 1.90.0 milestone Jul 25, 2025
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jul 28, 2025
@bors
Auto merge of #144440 - matthiaskrgr:rollup-peb88gb, r=matthiaskrgr
2f09023 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
 - rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
 - rust-lang/rust#143424 (clippy fix: rely on autoderef)
 - rust-lang/rust#143970 (Update core::mem::copy documentation)
 - rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
 - rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
 - rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
 - rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
 - rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
 - rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
 - rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
 - rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jul 28, 2025
@bors
Auto merge of #144440 - matthiaskrgr:rollup-peb88gb, r=matthiaskrgr
c2c1ab1 
Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#142569 (Suggest clone in user-write-code instead of inside macro)
 - rust-lang/rust#143401 (tests: Don't check for self-printed output in std-backtrace.rs test)
 - rust-lang/rust#143424 (clippy fix: rely on autoderef)
 - rust-lang/rust#143970 (Update core::mem::copy documentation)
 - rust-lang/rust#143979 (Test fixes for Arm64EC Windows)
 - rust-lang/rust#144200 (Tweak output for non-`Clone` values moved into closures)
 - rust-lang/rust#144209 (Don't emit two `assume`s in transmutes when one is a subset of the other)
 - rust-lang/rust#144314 (Hint that choose_pivot returns index in bounds)
 - rust-lang/rust#144340 (UI test suite clarity changes: Rename `tests/ui/SUMMARY.md` and update rustc dev guide on `error-pattern`)
 - rust-lang/rust#144368 (resolve: Remove `Scope::CrateRoot`)
 - rust-lang/rust#144390 (Remove dead code and extend test coverage and diagnostics around it)
 - rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`)

r? `@ghost`
`@rustbot` modify labels: rollup
tautschnig added a commit to tautschnig/kani that referenced this pull request Jul 29, 2025
@tautschnig
Upgrade Rust toolchain to 2025-07-25
33e6715 
Relevant upstream PRs:
- rust-lang/rust#144389 (MIR-build: No longer
  emit assumes in enum-as casting)
- rust-lang/rust#144392 (rustc_public: Remove
  movability from `RigidTy/AggregateKind::Coroutine`)
- rust-lang/rust#144377 (Rename impl_of_method
  and trait_of_item)

Resolves: model-checking#4246
@tautschnig tautschnig mentioned this pull request Jul 29, 2025
Merged
github-merge-queue bot pushed a commit to model-checking/kani that referenced this pull request Jul 29, 2025
@tautschnig
Upgrade Rust toolchain to 2025-07-29 (#4247)
bd6c8cf 
Relevant upstream PRs:
- rust-lang/rust#144389 (MIR-build: No longer
emit assumes in enum-as casting)
- rust-lang/rust#144392 (rustc_public: Remove
movability from `RigidTy/AggregateKind::Coroutine`)
- rust-lang/rust#144377 (Rename impl_of_method
and trait_of_item)

Resolves: #4246

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@makai410 @rustbot @scottmcm @bors