-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Make tier 3 musl targets link dynamically by default #144410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since we don't build std for these and don't provide any support for them, these can trivially be changed to link dynamically by default. Signed-off-by: Jens Reidel <[email protected]>
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
These commits modify compiler targets. |
Pinging target maintainers as a heads-up:
|
Just FYI, the hexagon target already links dynamically by default, I just removed the explicit line there since the default musl target already links dynamically. So hexagon doesn't change behavior here :) |
Thanks - LGTM. |
IIRC, there was an official decision to switch all musl targets to dynamically-linked-by-default, which didn't turn into an actual implementation. |
It (partially) did, the base linux_musl target is dynamically linked now, so any new targets will be dynamically linked. Noone has taken onto the existing ones yet. I'm working on implementing the lint that was proposed in the MCP as a step towards changing the tier 2 targets to be dynamically linked, but that lint isn't necessary to change the tier 3 targets like done in this PR. The original MCP is rust-lang/compiler-team#422 |
@jieyouxu hi there, it's been a week so I was wondering whether this could be merged? |
I believe this was rust-lang/compiler-team#422. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging from the thumb ups and explicit approvals, there is consensus in favor of this change from all pinged target maintainers. Since these targets are all Tier 3 and do not have pre-compiled std, we can make this change without too much hassle.
Thanks! I'll tag this with relnotes just so users of these targets might have a chance to be aware of this change. |
…eyouxu Make tier 3 musl targets link dynamically by default Since we don't build std for these and don't provide any support for them, these can trivially be changed to link dynamically by default.
Rollup of 6 pull requests Successful merges: - #144397 (`tests/ui/issues/`: The Issues Strike Back [2/N]) - #144410 (Make tier 3 musl targets link dynamically by default) - #144708 (Add tracing to step.rs and friends) - #144730 (Create a typed wrapper for codegen backends in bootstrap) - #144771 (Remove some noisy triagebot pings for myself) - #144772 (add unsupported_calling_conventions to lint list) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #144410 - Gelbpunkt:musl-tier3-dynamic, r=jieyouxu Make tier 3 musl targets link dynamically by default Since we don't build std for these and don't provide any support for them, these can trivially be changed to link dynamically by default.
Since we don't build std for these and don't provide any support for them, these can trivially be changed to link dynamically by default.