Add a diagnostic for similarly named traits #144674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Jul 30, 2025
compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs
Outdated
Show resolved
Hide resolved
…equired one This is useful when you have two dependencies that use different trait for the same thing and with the same name. The user can accidentally implement the bad one which might be confusing.
rperier
force-pushed
the
add_note_if_a_type_impl_a_trait_with_the_same_name
branch
from
ff869dc to
abdb087
Compare
|
This PR modifies cc @jieyouxu |
|
Fixed by using predicate_must_hold_modulo_regions |
lcnr
reviewed
Aug 1, 2025
Comment on lines
+5133
to
+5135
| trait_ref | ||
| .skip_binder() | ||
| .with_self_ty(self.tcx, trait_predicate.skip_binder().self_ty()), |
There was a problem hiding this comment.
skip_binder is pretty much never correct:
also see https://rustc-dev-guide.rust-lang.org/typing_parameter_envs.html
U will also need to properly handle the generic parameters of the traits here, e.g. what if we've got trait Trait {} and a separate trait Trait<T> {}
Also, check predicate must hold for the other trait, not per impl.
There was a problem hiding this comment.
Mhhhh, I see. I have to document myself about this part, thanks for the links.
Also, check predicate must hold for the other trait, not per impl.
Would you have a usecase for this ? You're probably right, but I don't get it.
thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #133123
This is a first proposal, suggestions are welcome