Skip to content

Stabilize strict_overflow_ops #144682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stabilize strict_overflow_ops #144682

wants to merge 2 commits into from
+56 −103

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 30, 2025 •
edited
Loading

Closes #118260

@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2025

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nxsaken nxsaken force-pushed the strict_overflow_ops branch from 54af655 to 3ff3a1e Compare July 30, 2025 19:39
@nxsaken
Copy link
Contributor Author

nxsaken commented Jul 30, 2025

I see a mention of strict_overflow_ops in src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs, but I'm not sure if I should manually change stuff in a generated directory.

@Mark-Simulacrum
Copy link
Member

I think it should be ok to edit that file - see e.g. 53c1301 as a prior example.

@Mark-Simulacrum
Copy link
Member

r=me with that done

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@nxsaken
Copy link
Contributor Author

nxsaken commented Aug 4, 2025

ping @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 5, 2025

📌 Commit 17241a7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 5, 2025
@Zalathar
Rollup merge of rust-lang#144682 - nxsaken:strict_overflow_ops, r=Mar…
c710bb7 
…k-Simulacrum

Stabilize `strict_overflow_ops`

Closes rust-lang#118260
@Zalathar Zalathar mentioned this pull request Aug 5, 2025
Open
bors added a commit that referenced this pull request Aug 5, 2025
@bors
Auto merge of #144942 - Zalathar:rollup-ovblxsy, r=Zalathar
1a2c45a 
Rollup of 16 pull requests

Successful merges:

 - #143857 (Port #[macro_export] to the new attribute parsing infrastructure)
 - #144133 (Stabilize const TypeId::of)
 - #144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny)
 - #144443 (Make target pointer width in target json an integer)
 - #144473 (Address libunwind.a inconsistency issues in the bootstrap program)
 - #144659 (bootstrap: refactor mingw dist and fix gnullvm)
 - #144682 (Stabilize `strict_overflow_ops`)
 - #144794 (Port `#[coroutine]` to the new attribute system)
 - #144835 (Anonymize binders in tail call sig)
 - #144836 (Change visibility of Args new function)
 - #144900 (Stabilize `unsigned_signed_diff` feature)
 - #144903 (Rename `begin_panic_handler` to `panic_handler`)
 - #144910 (Add regression tests for seemingly fixed issues)
 - #144926 (Correct the use of `must_use` on btree::IterMut)
 - #144928 (Drop `rust-version` from `rustc_thread_pool`)
 - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC)

Failed merges:

 - #144914 (Add support for `ty::Instance` path shortening in diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for arithmetic that panics on overflow (strict_* operations)
5 participants
@nxsaken @rustbot @rust-log-analyzer @Mark-Simulacrum @bors