Rollup of 3 pull requests #144723

Zalathar · 2025-07-31T08:52:12Z

Successful merges:

fix: Only "close the window" when its the last annotated file #144657 (fix: Only "close the window" when its the last annotated file)
Re-block SRoA on SIMD types #144665 (Re-block SRoA on SIMD types)
rustc_middle::ty cleanups #144713 (rustc_middle::ty cleanups)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Fixes 144621

It's not used in `rustc_middle`, and `rustc_resolve` is a better place for it.

It's not used in `rustc_middle`, and `rustc_trait_selection` is a better place for it.

Next to all the other `EarlyParamRegion` pieces.

It's only used in `rustc_hir_typeck`.

It's only used in `rustc_infer`.

The fields are public, so this doesn't need a method, normal deconstruction and/or field access is good enough.

It's identical to `TyCtxt::get_all_attrs` except it takes `DefId` instead of `impl Into<DefIf>`.

It's only used in `rustc_hir_typeck`.

- Put them in the module that defines the type. - Add some `WithCachedTypeInfo<T>` asserts for consistency.

… r=fee1-dead fix: Only "close the window" when its the last annotated file While comparing the Unicode theme output of `rustc` and `annotate-snippets`, I found that `rustc` would ["close the window"](https://github.com/rust-lang/rust/blob/686bc1c5f9c06762b18082434c04d514acf6707e/compiler/rustc_errors/src/emitter.rs#L1025-L1027) (draw a `╰╴`), even though there were other annotated files that followed the current one. This PR makes it so the emitter will only "close the window" on the last annotated file. Before: ``` error[E0624]: method `method` is private ╭▸ $DIR/close_window.rs:9:7 │ LL │ s.method(); ╰╴ ━━━━━━ private method │ ⸬ $DIR/auxiliary/close_window.rs:3:5 │ LL │ fn method(&self) {} ╰╴ ──────────────── private method defined here ``` After: ``` error[E0624]: method `method` is private ╭▸ $DIR/close_window.rs:9:7 │ LL │ s.method(); │ ━━━━━━ private method │ ⸬ $DIR/auxiliary/close_window.rs:3:5 │ LL │ fn method(&self) {} ╰╴ ──────────────── private method defined here ```

…r=compiler-errors Re-block SRoA on SIMD types Fixes rust-lang#144621

…ps, r=lcnr `rustc_middle::ty` cleanups r? `@davidtwco`

Zalathar · 2025-07-31T08:52:23Z

@bors r+ rollup=never p=5

bors · 2025-07-31T08:52:26Z

📌 Commit 017586c has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-07-31T08:54:44Z

⌛ Testing commit 017586c with merge 64ca23b...

bors · 2025-07-31T12:02:57Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 64ca23b to master...

rust-timer · 2025-07-31T12:03:52Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144657	fix: Only "close the window" when its the last annotated fi…	`0f84b830c32c930dd502bdbd73a3ab75c41942d5` (link)
#144665	Re-block SRoA on SIMD types	`eed7cb8ad3f941ae35cbd761cbdcf2181f904b0d` (link)
#144713	`rustc_middle::ty` cleanups	`1f819b3590e7a53dbd7d5c797b2fc38a14e830ff` (link)

previous master: cc0a5b7305

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-31T12:05:55Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cc0a5b7 (parent) -> 64ca23b (this PR)

Test differences

Show 26 test diffs

Stage 1

[mir-opt] tests/mir-opt/sroa/simd_sroa.rs: [missing] -> pass (J0)
[ui] tests/ui/error-emitter/close_window.rs#ascii: [missing] -> pass (J0)
[ui] tests/ui/error-emitter/close_window.rs#unicode: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/error-emitter/close_window.rs#ascii: [missing] -> pass (J1)
[ui] tests/ui/error-emitter/close_window.rs#unicode: [missing] -> pass (J1)
[mir-opt] tests/mir-opt/sroa/simd_sroa.rs: [missing] -> pass (J2)

Additionally, 20 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 64ca23b6235732fa61c0a2b957c5d7e591e7c972 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 7293.9s -> 4137.9s (-43.3%)
aarch64-apple: 4450.5s -> 6292.8s (41.4%)
x86_64-apple-1: 6397.5s -> 8412.7s (31.5%)
dist-aarch64-apple: 7047.3s -> 5029.2s (-28.6%)
dist-x86_64-windows-gnullvm: 7234.0s -> 5591.3s (-22.7%)
x86_64-gnu-llvm-19: 2999.7s -> 2723.6s (-9.2%)
dist-x86_64-apple: 10617.4s -> 9663.1s (-9.0%)
dist-aarch64-msvc: 4976.2s -> 5374.1s (8.0%)
x86_64-gnu-llvm-19-1: 3459.5s -> 3735.3s (8.0%)
dist-aarch64-linux: 6001.1s -> 5560.6s (-7.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-31T13:14:39Z

Finished benchmarking commit (64ca23b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 0.1%, secondary -7.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-7.0%	[-9.6%, -4.4%]	2
All ❌✅ (primary)	0.1%	[-2.2%, 2.3%]	2

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 468.739s -> 467.836s (-0.19%)
Artifact size: 376.79 MiB -> 376.81 MiB (0.00%)

scottmcm and others added 16 commits July 29, 2025 20:41

Re-block SRoA on SIMD types

fe08ba0

Fixes 144621

test: Check close window rendering

4643d9a

Remove unused impl_decodable_via_ref! entries.

2bf10de

Move ResolverOutputs out of rustc_middle.

e83c8cb

It's not used in `rustc_middle`, and `rustc_resolve` is a better place for it.

Move ImplHeader out of rustc_middle.

790ab94

It's not used in `rustc_middle`, and `rustc_trait_selection` is a better place for it.

Move an EarlyParamRegion impl block.

3a1f2d5

Next to all the other `EarlyParamRegion` pieces.

Move ParamTerm out of rustc_middle.

b44eb11

It's only used in `rustc_hir_typeck`.

Move TermVid out of rustc_middle.

c4e3cc0

It's only used in `rustc_infer`.

Remove ParamEnvAnd::into_parts.

a949c47

The fields are public, so this doesn't need a method, normal deconstruction and/or field access is good enough.

Remove TyCtxt::get_attrs_unchecked.

0b3c980

It's identical to `TyCtxt::get_all_attrs` except it takes `DefId` instead of `impl Into<DefIf>`.

Move InferVarInfo out of rustc_middle.

cf95e45

It's only used in `rustc_hir_typeck`.

Fix up size asserts.

7aec38b

- Put them in the module that defines the type. - Add some `WithCachedTypeInfo<T>` asserts for consistency.

fix: Only "close the window" when its the last annotated file

761c4e3

Rollup merge of rust-lang#144665 - scottmcm:restore-sroa-simd-check, …

8cca6bc

…r=compiler-errors Re-block SRoA on SIMD types Fixes rust-lang#144621

Rollup merge of rust-lang#144713 - nnethercote:rustc_middle-ty-cleanu…

017586c

…ps, r=lcnr `rustc_middle::ty` cleanups r? `@davidtwco`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 31, 2025

bors merged commit 64ca23b into rust-lang:master Jul 31, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 31, 2025

Zalathar deleted the rollup-f9e0rfo branch July 31, 2025 12:40

bors mentioned this pull request Jul 31, 2025

TypeTree support in autodiff #144197

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 3 pull requests #144723

Rollup of 3 pull requests #144723

Uh oh!

Zalathar commented Jul 31, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jul 31, 2025

Uh oh!

Uh oh!

Rollup of 3 pull requests #144723

Rollup of 3 pull requests #144723

Uh oh!

Conversation

Zalathar commented Jul 31, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

bors commented Jul 31, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jul 31, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Zalathar commented Jul 31, 2025 •

edited by rustbot

Loading