Skip to content

Create a typed wrapper for codegen backends in bootstrap #144730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

Create a typed wrapper for codegen backends in bootstrap #144730

merged 1 commit into from
Aug 1, 2025
+143 −79

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 31, 2025

To avoid representing them just with strings.

@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-bootstrap-stamp Area: bootstrap stamp logic A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Kobzol
Copy link
Member Author

Kobzol commented Jul 31, 2025

r? @jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Jul 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the bootstrap-cg-typed branch from e9c9b03 to 9cd36d4 Compare July 31, 2025 11:15
@Kobzol Kobzol mentioned this pull request Jul 31, 2025
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol Kobzol force-pushed the bootstrap-cg-typed branch from 9cd36d4 to 5445bbe Compare July 31, 2025 11:53
fbstj
fbstj reviewed Jul 31, 2025
View reviewed changes
fbstj
fbstj reviewed Jul 31, 2025
View reviewed changes
jieyouxu
jieyouxu approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some nits

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2025
@Kobzol
Create a typed wrapper for codegen backends
32f4876 
To avoid representing them just with strings.
@Kobzol Kobzol force-pushed the bootstrap-cg-typed branch from 5445bbe to 32f4876 Compare July 31, 2025 17:40
@Kobzol
Copy link
Member Author

Kobzol commented Jul 31, 2025

Applied review comments.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2025
jieyouxu
jieyouxu approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented Aug 1, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit 32f4876 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025
RalfJung added a commit to RalfJung/rust that referenced this pull request Aug 1, 2025
@RalfJung
Rollup merge of rust-lang#144730 - Kobzol:bootstrap-cg-typed, r=jieyouxu
541b84d 
Create a typed wrapper for codegen backends in bootstrap

To avoid representing them just with strings.
@RalfJung RalfJung mentioned this pull request Aug 1, 2025
Merged
bors added a commit that referenced this pull request Aug 1, 2025
@bors
Auto merge of #144773 - RalfJung:rollup-uif2yyj, r=RalfJung
924a5a4 
Rollup of 6 pull requests

Successful merges:

 - #144397 (`tests/ui/issues/`: The Issues Strike Back [2/N])
 - #144410 (Make tier 3 musl targets link dynamically by default)
 - #144708 (Add tracing to step.rs and friends)
 - #144730 (Create a typed wrapper for codegen backends in bootstrap)
 - #144771 (Remove some noisy triagebot pings for myself)
 - #144772 (add unsupported_calling_conventions to lint list)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0ad0be9 into rust-lang:master Aug 1, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Aug 1, 2025
rust-timer added a commit that referenced this pull request Aug 1, 2025
@rust-timer
Unrolled build for #144730
be659de 
Rollup merge of #144730 - Kobzol:bootstrap-cg-typed, r=jieyouxu

Create a typed wrapper for codegen backends in bootstrap

To avoid representing them just with strings.
@Kobzol Kobzol deleted the bootstrap-cg-typed branch August 1, 2025 13:44
@Kobzol Kobzol mentioned this pull request Aug 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-bootstrap-stamp Area: bootstrap stamp logic A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kobzol @rustbot @rust-log-analyzer @jieyouxu @bors @fbstj @Mark-Simulacrum