Skip to content

Update cargo #144735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025
Merged

Update cargo #144735

merged 1 commit into from
Aug 1, 2025

Conversation

weihanglo
Copy link
Member

3 commits in a7fcef21feb4d835d1fee83b3f93b4aef86d5545..840b83a10fb0e039a83f4d70ad032892c287570a
2025-07-13 02:25:52 +0000 to 2025-07-30 13:59:19 +0000

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

Do this early due to a regression in TOML parsing (though unlikely to happen).

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

📌 Commit 42c520d has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2025
@bors
Copy link
Collaborator

bors commented Aug 1, 2025

⌛ Testing commit 42c520d with merge 4b55fe1...

@bors
Copy link
Collaborator

bors commented Aug 1, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4b55fe1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2025
@bors bors merged commit 4b55fe1 into rust-lang:master Aug 1, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Aug 1, 2025
Copy link
Contributor

github-actions bot commented Aug 1, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 924a5a4 (parent) -> 4b55fe1 (this PR)

Test differences

Show 5 test diffs

Stage 2

  • sources::registry::index::escaped_char_in_index_json_blob: pass -> [missing] (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4b55fe199cfe9c710555a5af7f2a49491ad38254 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7445.0s -> 5643.3s (-24.2%)
  2. x86_64-apple-1: 8294.4s -> 6309.5s (-23.9%)
  3. pr-check-1: 1807.8s -> 1507.7s (-16.6%)
  4. pr-check-2: 2715.8s -> 2287.1s (-15.8%)
  5. aarch64-gnu-llvm-19-1: 3662.1s -> 3109.9s (-15.1%)
  6. aarch64-gnu-debug: 4281.9s -> 3676.2s (-14.1%)
  7. x86_64-apple-2: 5829.0s -> 5016.9s (-13.9%)
  8. x86_64-rust-for-linux: 2917.7s -> 2523.5s (-13.5%)
  9. x86_64-gnu-debug: 6348.5s -> 5544.6s (-12.7%)
  10. x86_64-gnu-tools: 3782.0s -> 3314.5s (-12.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4b55fe1): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.376s -> 467.125s (-0.27%)
Artifact size: 376.79 MiB -> 376.83 MiB (0.01%)

@weihanglo weihanglo deleted the update-cargo branch August 1, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants