more strongly dissuade use of skip_binder
#144775
Conversation
rustbot
added
S-waiting-on-review
lcnr
force-pushed
the
skip_binder-comment
branch
from
78b4cd0 to
fc46354
Compare
| /// Please read <https://rustc-dev-guide.rust-lang.org/ty_module/instantiating_binders.html> | ||
| /// before using this function. It is usually better to discharge the binder using | ||
| /// `no_bound_vars` or `instantiate_bound_regions` or something like that. |
There was a problem hiding this comment.
Consider wrapping this and maybe its following paragraphs in a big warning block by surrounding it with <div class="warning"> </div> (note: there needs to be a blank line between the HTML tags and the Markdown content or else the latter would be interpreted as HTML), similarly for the EarlyBinder case.
These get rendered like so: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/struct.TyCtxt.html#method.expand_free_alias_tys
There was a problem hiding this comment.
Hm, I feel I'd need to already mark the "Accessing generic args in the returned value is generally incorrect." as a warning, but that's part of the first line.
I personally don't know how I'd restructure this to add a warning block and would merge this as is
People unfortunately encounter
BinderandEarlyBindervery early on when starting out. In these cases its often very easy to useskip_binderincorrectly. This makes it more explicit that it should generally not be used and points to the relevantrustc-dev-guidechapters.r? @BoxyUwU