-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Refactor codegen backends in bootstrap #144787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kobzol
wants to merge
24
commits into
rust-lang:master
Choose a base branch
from
Kobzol:codegen-backend-restructure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,014
−638
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b6f12d7
Rename extended rustc tool macros
Kobzol 65c3597
Add metadata to `Cargo` and `RustAnalyzer` tools
Kobzol 57a6c93
Cleanup `ensure_if_default` to not require `Option` output
Kobzol 8fed3fb
Add step metadata to `RustAnalyzerProcMacroSrv`
Kobzol 2f3bfff
Rename `Builder::rustdoc` to `Builder::rustdoc_for_compiler`
Kobzol 6d562b2
Implement `RustcPrivateCompilers` to unify building of `rustc_private…
Kobzol b944144
Add step metadata and a few tests for `Doc` steps
Kobzol 2c7581f
Refactor `Rustdoc`
Kobzol 91d40d2
Fix `ToolRustc` build with `download-rustc`
Kobzol 7a2c4d3
Add step metadata and a simple test for codegen backends
Kobzol 06855be
Port codegen backends to `RustcPrivateCompilers`
Kobzol c3da07b
Rename `link_compiler` to `target_compiler`
Kobzol 0ff8ff3
Appease Clippy
Kobzol 316b5d3
Add basic Cargo snapshot test
Kobzol 21d7a54
Make `Cargo` a `ToolTarget` tool
Kobzol 021f2ff
Update `CargoTest`
Kobzol 3e6aa81
Add snapshot tests for `test cargo` and update Cargo snapshot tests
Kobzol 528e7dc
Make build compiler explicit in `dist::Cargo`
Kobzol 1d1efed
Fix `x test cargo`
Kobzol 47da014
Make `x test cargo` stage N test rustc stage N
Kobzol c46f42d
Clarify comments on Cargo (self-)test steps
Kobzol d007145
Split CodegenBackend step into two and handle stamp sysroot copy expl…
Kobzol 669a9e0
Refactor `dist::CraneliftCodegenBackend`
Kobzol 588f96f
Clarify the behavior of `rust.codegen-backends`
Kobzol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment: this is exactly the behaviour I wanted, thanks so much for implementing it!
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the existing behavior, I didn't change it in this PR, just documented it and refactored it :D The only change is that it is now possible to build a backend even if it isn't in the array in the config file.