-
Notifications
You must be signed in to change notification settings - Fork 13.6k
resolve: Split extern prelude into two scopes #144793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Do not write dummy bindings to extern prelude. Use more precise `Used::Scope` while recording use and remove now redundant `introduced_by_item` check.
One for `--extern` options and another for `extern crate` items.
r? @davidtwco rustbot has assigned @davidtwco. Use |
This comment was marked as resolved.
This comment was marked as resolved.
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
resolve: Split extern prelude into two scopes
Unknown labels: S-waiting-on-perf |
The job Click to see the possible cause of the failure (guessed by this bot)
|
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (7203fa8): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.0%, secondary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 467.125s -> 467.279s (0.03%) |
(Based on #144746.)
One scope for
extern crate
items and another for--extern
options, with the former shadowing the latter.If in a single scope some things can overwrite other things, especially with ad hoc restrictions like
MacroExpandedExternCrateCannotShadowExternArguments
, then it's not really a single scope.So this PR splits
Scope::ExternPrelude
into two cleaner scopes.