Skip to content

Streamline config in bootstrap #144807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Streamline config in bootstrap #144807

wants to merge 27 commits into from
+935 −951

Conversation

Shourya742
Copy link
Contributor

This PR restructures the config module to improve readability and debuggability. It also aims to eliminate as many invariants as possible. Best reviewed commit by commit.

r? @Kobzol

Shourya742 added 26 commits August 1, 2025 20:26
@Shourya742
move gcc config parsing to parse_inner
f95edbe
@Shourya742
move dist to parse_inner
3f9bf57
@Shourya742
move target parsing to parse_inner
924912c
@Shourya742
move install to parse_inner
89219ff
@Shourya742
move llvm parsing to parse_inner
3248ff1
@Shourya742
move rust config to parse_inner
ddd2a54
@Shourya742
Force initializing ExecutionContext with verbosity and fail_fast mode
ae05591
@Shourya742
Extract TOML config loading and src directory computation into separa…
82756fd 
…te functions
@Shourya742
Split TOML postprocessing into a separate function
f89ea08
@Shourya742
Override some build TOML values by flags
cfc40de
@Shourya742
Fix logging of config skip values
8652d96
@Shourya742
Fix verbosity setting
58a38cd
@Shourya742
add install default implementation
222dfcc
@Shourya742
add gcc and dist default implementation
bbe7c08
@Shourya742
add llvm default implementation
38ddefa
@Shourya742
add rust default implementation
8b80cb0
@Shourya742
make llvm toml fields follow a specific naming convention
d3d3b10
@Shourya742
make gcc toml fields follow a specific naming convention
c008a4b
@Shourya742
make dist toml fields follow a specific naming convention
4d2a2c2
@Shourya742
make install toml fields follow a specific naming convention
ad98550
@Shourya742
make build toml fields follow a specific naming convention
2c96132
@Shourya742
move build config to the top of parse method
a75326b
@Shourya742
move install config to the top of parse method
39d9cf7
@Shourya742
move rust config to the top of parse method
120d93e
@Shourya742
move llvm config to the top of parse method
f74f1a0
@Shourya742
move dist and gcc config to the top of parse method
7f20ad8
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Shourya742 Shourya742 marked this pull request as draft August 2, 2025 06:14
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Kobzol
Kobzol reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would stop before eb81f72 in this PR, it already has a lot of changes. Left some comments. Looks great!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Shourya742 Shourya742 force-pushed the 2025-07-30-streamline-config branch from 87966f4 to cf03a40 Compare August 4, 2025 15:19
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Shourya742 Shourya742 force-pushed the 2025-07-30-streamline-config branch from cf03a40 to b32ded3 Compare August 4, 2025 16:07
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Shourya742 Shourya742 force-pushed the 2025-07-30-streamline-config branch from b32ded3 to 888edc0 Compare August 4, 2025 16:40
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Shourya742 Shourya742 force-pushed the 2025-07-30-streamline-config branch from 888edc0 to a2794f9 Compare August 4, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@Kobzol Kobzol

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shourya742 @rustbot @rust-log-analyzer @Kobzol