Anonymize binders in tail call sig #144835
Open
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
lqd
reviewed
Aug 2, 2025
| @@ -63,6 +63,10 @@ impl<'tcx> TailCallCkVisitor<'_, 'tcx> { | |||
| "`become` outside of functions should have been disallowed by hit_typeck" | |||
There was a problem hiding this comment.
(maybe while you're here)
Suggested change
| "`become` outside of functions should have been disallowed by hit_typeck" | |
| "`become` outside of functions should have been disallowed by hir_typeck" |
lqd
reviewed
Aug 2, 2025
| //@ check-pass | ||
|
|
||
| #![feature(explicit_tail_calls)] | ||
| //~^ WARN the feature `explicit_tail_calls` is incomplete |
There was a problem hiding this comment.
(while I'm here, maybe a little #![allow(incomplete_features)] to remove the unnecessary stderr?!)
There was a problem hiding this comment.
I personally prefer the warn because it forces it being removed when the feature gets un-incomplete-ified
There was a problem hiding this comment.
All other tail call tests use #![expect(incomplete_features)]
22 tasks
compiler-errors
force-pushed
the
tail-call-sig-binder
branch
from
fbf7ebf to
f6ce4ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comment for explanation
Fixes #144826
r? WaffleLapkin