Rewriteis_ascii
using slice::as_chunks
#144837
Open
+26
−153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the x86-64+sse2 version of
is_ascii
to be architecture-neutral, and rewrite it usingslice::as_chunks
. The new version is both shorter (in terms of Rust source code) and smaller (in terms of produced assembly).Compare the assembly generated before and after:
https://godbolt.org/z/MWKdnaYoK