Port #[allow_internal_unsafe] to the new attribute system
#144857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_hir/src/attrs |
scrabsha
changed the title
#[allow_internal_unsafe] to the new attribute system#[allow_internal_unsafe] to the new attribute system
scrabsha
force-pushed
the
push-pwtyrnmqkrtr
branch
from
da3e3f7 to
4c5e5a9
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-pwtyrnmqkrtr
branch
from
4c5e5a9 to
0404952
Compare
9 tasks
jdonszelmann
approved these changes
Aug 4, 2025
| if attr.has_name(sym::allow_internal_unsafe) { | ||
| if AttributeParser::parse_limited( | ||
| cx.builder.sess(), | ||
| slice::from_ref(attr), |
There was a problem hiding this comment.
I didn't know this function existed
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
|
oops, conflicts |
|
@bors delegate+ r=me after a rebase |
|
✌️ @scrabsha, you can now approve this pull request! If @jdonszelmann told you to " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #131229 (comment).
r? @jdonszelmann