Skip to content

Stabilize panic_payload_as_str feature #144861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize panic_payload_as_str feature #144861

wants to merge 1 commit into from
+1 −3

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Aug 3, 2025 •
edited
Loading

Closes tracking issue.

Part of #116005.

FCP ended more than year ago in tracking issue, I'm not sure if we should rerun it.

@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2025
@ChrisDenton
Copy link
Member

This seems fine to me but yeah, given the length of time I'd like to ask for confirmation from @rust-lang/libs-api

@ChrisDenton ChrisDenton added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2025
@m-ou-se m-ou-se added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Aug 4, 2025
@m-ou-se m-ou-se mentioned this pull request Aug 5, 2025
Open
3 tasks
@ChrisDenton
Copy link
Member

This was discussed in the libs-api meeting and it was confirmed that libs-api are still happy to stabilize this. Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 5, 2025

📌 Commit 74e85a2 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 5, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Aug 5, 2025
@ChrisDenton ChrisDenton removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChrisDenton ChrisDenton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for PanicHookInfo::payload_as_str()
5 participants
@Kivooeo @rustbot @ChrisDenton @bors @m-ou-se