Skip to content

Stabilize path_file_prefix feature #144870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Aug 3, 2025

This stabilises Path::file_prefix, following the FCP in tracking issue

(FCP ended almost a year ago, so if it's needed for proccess we could rerun it)

@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 3, 2025
@rust-log-analyzer

This comment has been minimized.

@Kivooeo Kivooeo force-pushed the file_prefix-stabilize branch from 8235756 to 0fc453f Compare August 3, 2025 20:32
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Aug 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

@Kivooeo Kivooeo force-pushed the file_prefix-stabilize branch from 0fc453f to 4c4b8b2 Compare August 3, 2025 21:18
@jieyouxu
Copy link
Member

jieyouxu commented Aug 4, 2025

FWIW there seems to be an outstanding concern #86319 (comment)

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Aug 4, 2025

I saw that but it seems like it's about adding another function, right? Or they want to make this new function a part of this stabilizaton?

@jieyouxu
Copy link
Member

jieyouxu commented Aug 4, 2025

cc @the8472 (I don't know)

@the8472
Copy link
Member

the8472 commented Aug 4, 2025

I was suggesting to make this part of this function. Alas, nobody responded to that suggestion.
It's rather late in the process and current API was already approved so you're not required to make that change, but I'll nominate it for discussion so the team can take another look at it.

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Aug 4, 2025

We can open FCP to add this as an additional function to this and make it part of this feature in this PR, because I also think that this is better to return both parts

This wasn't fully discussed at the time, so I think it's worth addressing now, and I believe it's better late than never

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants