-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Stabilize path_file_prefix
feature
#144870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
8235756
to
0fc453f
Compare
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
0fc453f
to
4c4b8b2
Compare
FWIW there seems to be an outstanding concern #86319 (comment) |
I saw that but it seems like it's about adding another function, right? Or they want to make this new function a part of this stabilizaton? |
cc @the8472 (I don't know) |
I was suggesting to make this part of this function. Alas, nobody responded to that suggestion. |
We can open FCP to add this as an additional function to this and make it part of this feature in this PR, because I also think that this is better to return both parts This wasn't fully discussed at the time, so I think it's worth addressing now, and I believe it's better late than never |
This stabilises
Path::file_prefix
, following the FCP in tracking issue(FCP ended almost a year ago, so if it's needed for proccess we could rerun it)