-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Implement stability_implications
without a visitor.
#144873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Implement `stability_implications` without a visitor.
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (6c6c56e): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.0%, secondary 3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.2%, secondary 3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 467.629s -> 465.94s (-0.36%) |
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, r=me w/ nit
@@ -313,6 +318,42 @@ impl DefKind { | |||
) | |||
} | |||
|
|||
pub fn has_generics(self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there can be a better name, like can contain generics or something? + a doc comment, e.g. at least mentioning generics_of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modeled the name after pre-existing has_codegen_attrs
. Added a doc-comment.
🚀 @bors r+ |
Since #143845, the
Annotator
visitor was a no-op when the crate is not staged_api. This PR avoids using a visitor altogether, makingstability_implications
truly a no-op in most cases.