-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix parallel rustc not being reproducible due to unstable sorts of items #144886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Fix parallel rustc not being reproducible due to unstable sorts of items
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (8bf70d1): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 3.4%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 24.6%, secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 468.82s -> 467.885s (-0.20%) |
Currently, A tuple
(DefId, SymbolName)
is used to determine the order of items in the final binary. HoweverDefId
is expected as non-deterministic, which leads to some not reproducible issues under parallel compilation.Here we use
(Span, SymbolName)
to replace(DefId, SymbolName)
and make them sorted.This PR is purposed to fix #140425, but seemly works on #140413 too.
This behavior hasn't added into any test until we have a test suit for the parallel frontend. (See #143953)
Related discussion: Zulip #144576
Update #113349
r? @SparrowLii