print raw lifetime idents with r# #144897
Conversation
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
|
This PR modifies |
compiler/rustc_span/src/symbol.rs
Outdated
| if let Some(ident) = self.as_raw_lifetime_name_without_apostrophe() { | ||
| write!(f, "'{}", IdentPrinter::new(ident.name, true, None)) | ||
| } else { | ||
| fmt::Display::fmt(&IdentPrinter::new(self.name, self.is_raw_guess(), None), f) | ||
| } |
There was a problem hiding this comment.
Why is this not a change in IdentPrinter instead?
There was a problem hiding this comment.
How do you propose us to make the check in IdentPrinter? It doesn't know about editions because it only accepts the symbol. is_raw_guess and as_raw_lifetime_name_without_apostrophe both need the span edition to know whether some identifier is treated as a keyword or not.
There was a problem hiding this comment.
I suppose it could accept edition as a parameter? otherwise I'm not sure what's even the point of it
There was a problem hiding this comment.
otherwise I'm not sure what's even the point of it
Just looked at the code again. IdentPrinter is used from two general places. One where one has the token data (sorta at the parsing/ast/proc macro stage) in which rawness of idents are known and do not need to be guessed, and one at a later stage where they do. that's why rawness was originally passed as a bool. To improve the design as you highlighted I chose to change the original bool into an enum, but we still have to guess whether a raw lifetime should be printed here and not inside IdentPrinter.
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
raw_lifetimes_printing
branch
2 times, most recently
from
5805f0a to
9705706
Compare
| | | ||
| help: consider introducing lifetime `'r#fn` here | ||
| | | ||
| LL | fn a<'fn>(_: dyn Trait + 'r#fn) { |
There was a problem hiding this comment.
It doesn't actually sugg 'r#fn here and one and two below
There was a problem hiding this comment.
uh.... that must have changed between my blesses or smth. Will take a look
fee1-dead
force-pushed
the
raw_lifetimes_printing
branch
from
9705706 to
b74a97e
Compare
This replaces #143185 and fixes #143150
cc @fmease