Skip to content

Require approval from t-infra instead of t-release on tier bumps #144906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 4, 2025

Discussed at https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tier.201.20target.20promotion.20RFC.20FCP.20sign-offs/with/532735844.

I also changed "viability and value" to just "viability". I think that t-infra should decide whether it's viable to support a given target on our CI. The value should be determined by t-compiler.

r? @jieyouxu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. I would like a compiler lead to sign-off, since it's technically a change in how we do Tier 1 target promotions.

@jieyouxu
Copy link
Member

jieyouxu commented Aug 4, 2025

r? compiler_leads

@rustbot rustbot assigned davidtwco and unassigned jieyouxu Aug 4, 2025
@wesleywiser
Copy link
Member

Has the release team weighed in on this? I agree this conceptually makes more sense but since the original policy was the result of an RFC, I think we should do a T-release/T-infra FCP to confirm this is what both teams want.

@Kobzol
Copy link
Member Author

Kobzol commented Aug 4, 2025

I asked Mark, who was fine with it (along with most members of t-infra), but yeah, we should probably involve the whole release team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants