[rustdoc] Fix wrong i tooltip icon
#144913
Open
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-wrong-i-icon
branch
from
1eb2d44 to
2260749
Compare
lolbinarycat
reviewed
Aug 4, 2025
| @@ -0,0 +1,15 @@ | |||
| // This test checks that the right font is applied to the `i` tooltip element. | |||
There was a problem hiding this comment.
I think this should probably mention this is technically a regression test for #144778 (and also the PR description should mention this fixes that issue)
lolbinarycat
reviewed
Aug 4, 2025
| @@ -767,3 +767,17 @@ pub mod impls_indent { | |||
| pub fn bar() {} | |||
| } | |||
| } | |||
|
|
|||
| pub mod tooltips { | |||
| pub struct X; | |||
There was a problem hiding this comment.
should we also try with <div class="warning"></div> like in the original issue, just to make sure?
There was a problem hiding this comment.
Like said above, can't reproduce the bug for this case. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current wrong display:
With the fix:
r? @fmease