Skip to content

Drop rust-version from rustc_thread_pool #144928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop rust-version from rustc_thread_pool #144928

wants to merge 1 commit into from
+0 −1

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Aug 4, 2025

The current rust-version = "1.63" was inherited from rayon, but it
doesn't make sense to limit this in the compiler workspace. Having any
setting at all has effects on tools like cargo info that try to infer
the MSRV when the workspace itself doesn't specify it. Since we are the
compiler, our only MSRV is whatever bootstrapping requires.

@cuviper
Drop rust-version from rustc_thread_pool
81edf2b 
The current `rust-version = "1.63"` was inherited from rayon, but it
doesn't make sense to limit this in the compiler workspace. Having any
setting at all has effects on tools like `cargo info` that try to infer
the MSRV when the workspace itself doesn't specify it. Since we are the
compiler, our only MSRV is whatever bootstrapping requires.
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
@cuviper
Copy link
Member Author

cuviper commented Aug 4, 2025

Having any setting at all has effects on tools like cargo info that try to infer the MSRV when the workspace itself doesn't specify it.

For example, I was confused why cargo info bindgen-cli was giving me an older version while I happened to be in my rust worktree, even though that crate is not anywhere in our lockfiles.

@lqd
Copy link
Member

lqd commented Aug 4, 2025

Right, good spot. r=me when green

@cuviper
Copy link
Member Author

cuviper commented Aug 4, 2025

@bors r=lqd rollup

@bors
Copy link
Collaborator

bors commented Aug 4, 2025

📌 Commit 81edf2b has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @rustbot @lqd @bors @petrochenkov