Rollup of 17 pull requests #144934
Open
Rollup of 17 pull requests #144934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All settings are now phrased in the imperative form stating what the setting does rather than talking about what it controls. (E.g.: "Show `Debug` action." instead of "Whether to show `Debug` action" - Categories are now displayed in title case - Categories are now sorted lexicographically - General category is removed (and all the settings are moved to the top level) - Language for a few descriptions is made a bit less ambiguous
And add assert_eq, assert_ne, assert_matches support
Input:
```rust
pub fn $0foo(x: bool) {
debug_assert!(x);
}
```
Old:
```rust
/// .
///
/// # Panics
///
/// Panics if .
pub fn foo(x: bool) {
debug_assert!(x);
}
```
This PR fixes:
```rust
/// .
pub fn foo(x: bool) {
debug_assert!(x);
}
```
Signed-off-by: Hayashi Mikihiro <[email protected]>
…` to SyntaxEditor Signed-off-by: Hayashi Mikihiro <[email protected]>
…ditor' Signed-off-by: Hayashi Mikihiro <[email protected]>
- this removes one external dependency, mdbook-toc - this steals code from rustc book
…-gen Fix gen panics doc template for debug_assert
fix: Do not require all rename definitions to be renameable
Use GH app for authenticating sync PRs
…t support snippets
…l-snippet fix: In generate_mut_trait_impl, don't add a tabstop if the client does not support snippets
Improve settings tree title and descriptions
… `impl Trait`, collect only the bounds of this projection It used to collect the bounds of them all.
…hints fix: When displaying a projection into a type parameter that has bounds as `impl Trait`, collect only the bounds of this projection
…le_struct_to_named_struct Migrate `convert_tuple_struct_to_named_struct` assist to use `SyntaxEditor`
…_alias_to_syntax_editor Migrate `inline_type_alias` assist to use `syntax_editor`
Reorganize proc-macro-srv more, add `--format` and `--version` args
Implement debugging output of the bootstrap Step graph into a DOT file There are already a bunch of ways how we can debug bootstrap, so why not add one more =D (ideally I'd like to consolidate these approaches somewhat, ```@Shourya742``` is looking into that, but I think that this specific debugging tool is orthogonal to the rest of them, and is quite useful). This PR adds the option to render the bootstrap step graph into the DOT format, in order to understand what steps were executed, along with their fields (`Debug` output). Here you can see an example of the generated DOT files for the `BOOTSTRAP_TRACING=1 ./x build compiler --stage 2 --dry-run` command on x64 Linux. One is with cached deps (what this PR does), the other one without. [bootstrap-dot.zip](https://github.com/user-attachments/files/21548679/bootstrap-dot.zip) Visual example: <img width="1899" height="445" alt="image" src="https://github.com/user-attachments/assets/ae40e6d2-0ea8-48bb-b77e-6b21700b95ee" /> r? ```@jieyouxu```
Add a tidy check to prevent adding UI tests directly under `tests/ui/` This PR implements rust-lang/compiler-team#902. Only the last commit (adding the new check) is functional; earlier commits are just small drive-by changes to make the other ui/ui-fulldeps checks more logically contained. r? ```@Kobzol``` (or compiler)
Properly reject tail calls to `&FnPtr` or `&FnDef` Fixes rust-lang#144795
Rename `rust_panic_without_hook` to `resume_unwind` part of rust-lang#116005 r? libs
…=jdonszelmann Remove `SHOULD_EMIT_LINTS` in favor of `should_emit` r? ``@jdonszelmann``
Use `as_array` in PartialEq for arrays Now that `as_array` exists we might as well use it here, since it's a bit more convenient than getting the correct type out of `try_into`.
…manieu Document Poisoning in `LazyCell` and `LazyLock` Currently, there is no documentation of poisoning behavior in either `LazyCell` or `LazyLock`, even though both of them can be observed as poisoned by users. `LazyCell` [plagyround example](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=9cf38b8dc56db100848f54085c2c697d) `LazyLock` [playground example](https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f1cd6f9fe16636e347ebb695a0ce30c0) # Open Questions - [x] Is it worth making the implementation of `LazyLock` more complicated to ensure that the the panic message is `"LazyLock instance has previously been poisoned"` instead of `"Once instance has previously been poisoned"`? See the `LazyLock` playground link above for more context. - [x] Does it make sense to move `LazyLock` into the `poison` module? It is certainly a poison-able type, but at the same time it is slightly different from the 4 other types currently in the `poison` module in that it is unrecoverable. I think this is more of a libs-api question. ``@rustbot`` label +T-libs-api Please let me know if these open questions deserve a separate issue / PR!
coverage: Various small cleanups This PR is a collection of small coverage-related changes that I accumulated while working towards other coverage improvements. Each change should hopefully be fairly straightforward.
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@8d75311. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
Add `InterpCx::project_fields` I was hoping for a much bigger improvement and this is lukewarm at best ^^' Still, I think this makes sense.
…enton Delete `tests/ui/threads-sendsync/tcp-stress.rs` This stress test was originally introduced in 65cca4b to detect a UAF in `libuv` (see rust-lang#12823), but we no longer use `libuv`, so remove this test as it no longer serves its original purpose, and is causing flaky timeout failures. Closes rust-lang#144878 (by removing the test). r? libs
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@1263fc2. Created using https://github.com/rust-lang/josh-sync. r? ``@ghost``
Dont print arg span in MIR dump for tail call r? WaffleLapkin This makes the MIR dump for tail call terminators consistent w/ regular calls.
rustbot
added
A-attributes
|
@bors r+ p=5 rollup=never |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 5, 2025
Rollup of 17 pull requests Successful merges: - #144467 (rustdoc template font links only emit `crossorigin` when needed) - #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - #144776 (`Printer` cleanups) - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - #144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - #144867 (Use `as_array` in PartialEq for arrays) - #144872 (Document Poisoning in `LazyCell` and `LazyLock`) - #144877 (coverage: Various small cleanups) - #144887 (`rust-analyzer` subtree update) - #144890 (Add `InterpCx::project_fields`) - #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - #144905 (rustc-dev-guide subtree update) - #144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
crossoriginwhen needed #144467 (rustdoc template font links only emitcrossoriginwhen needed)tests/ui/issues/tests to other subdirectories undertests/ui/#144548 (Rehome 21tests/ui/issues/tests to other subdirectories undertests/ui/)[const]s inside blocks within legal positions #144741 (fix: Error on illegal[const]s inside blocks within legal positions)Printercleanups #144776 (Printercleanups)tests/ui/#144813 (Add a tidy check to prevent adding UI tests directly undertests/ui/)&FnPtror&FnDef#144817 (Properly reject tail calls to&FnPtror&FnDef)rust_panic_without_hooktoresume_unwind#144852 (Renamerust_panic_without_hooktoresume_unwind)SHOULD_EMIT_LINTSin favor ofshould_emit#144866 (RemoveSHOULD_EMIT_LINTSin favor ofshould_emit)as_arrayin PartialEq for arrays #144867 (Useas_arrayin PartialEq for arrays)LazyCellandLazyLock#144872 (Document Poisoning inLazyCellandLazyLock)rust-analyzersubtree update #144887 (rust-analyzersubtree update)InterpCx::project_fields#144890 (AddInterpCx::project_fields)tests/ui/threads-sendsync/tcp-stress.rs#144894 (Deletetests/ui/threads-sendsync/tcp-stress.rs)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup