we only merge candidates for trait and normalizes-to goals

[lcnr]

so change fn try_merge_responses to fn try_merge_candidates and just use candidates everywhere.

Potentially slightly faster than the alternative :3

r? @compiler-errors @BoxyUwU

[rustbot]

compiler-errors is not on the review rotation at the moment.
They may take a while to respond.

[lcnr]

@bors2 try @rust-timer queue

[rust-bors]

⌛ Trying commit 937c1cc with merge ce2c44b…

To cancel the try build, run the command @bors try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: ce2c44b (ce2c44b890537e8974156608bf9fdda64449dc02, parent: 0f353363965ebf05e0757f7679c800b39c51a07e)

[compiler-errors]

r=me if good perf

[rust-timer]

Finished benchmarking commit (ce2c44b): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.2%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.5%	[2.5%, 6.5%]	2
Regressions ❌ (secondary)	6.2%	[6.2%, 6.2%]	1
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	2
All ❌✅ (primary)	2.2%	[-2.4%, 6.5%]	3

Cycles

Results (secondary 3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.338s -> 468.788s (0.10%)
Artifact size: 376.93 MiB -> 376.94 MiB (0.00%)

[lcnr]

@bors r=compiler-errors rollup

[bors]

📌 Commit ea2c080 has been approved by compiler-errors

It is now in the queue for this repository.