Skip to content

Gate const trait syntax #144956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Gate const trait syntax #144956

wants to merge 1 commit into from
+29 −3

Conversation

fmease
Copy link
Member

@fmease fmease commented Aug 5, 2025 •
edited
Loading

Missed this during my review of #143879, huge apologies!
Fixes [after beta backport] #144958.

cc @fee1-dead
r? @BoxyUwU or anyone

@fmease fmease added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. PG-const-traits Project group: Const traits labels Aug 5, 2025
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

⚠️ Warning ⚠️

@fmease
Copy link
Member Author

fmease commented Aug 5, 2025

Not sure if stable-nominated actually makes sense since this hasn't literally hit branch stable yet, only beta. But beta will stable promoted soon / stable artifacts have been built already IIUC.

@jieyouxu
Copy link
Member

jieyouxu commented Aug 5, 2025 •
edited
Loading

Doesn't #143879 target 1.90.0? I.e. I don't think it would hit 1.89.0 stable right? If I got my versions right, it probably would need a beta backport but not a stable backport (?)

@fmease
Copy link
Member Author

fmease commented Aug 5, 2025

Ah ic ic, I didn't realize that the beta I was testing was 1.90. Oof ok

@jieyouxu

This comment was marked as resolved.

Sign in to view
@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Aug 5, 2025
BoxyUwU
BoxyUwU reviewed Aug 5, 2025
View reviewed changes
@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 5, 2025

r=me if CI passes

@fmease
Copy link
Member Author

fmease commented Aug 5, 2025

@bors r=BoxyUwU rollup

@bors
Copy link
Collaborator

bors commented Aug 5, 2025

📌 Commit 092c6f3 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

Assignees

@BoxyUwU BoxyUwU

Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmease @rustbot @jieyouxu @BoxyUwU @bors