Add instructions to test wasi (wasm32-wasip1) specific tests #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
jieyouxu
approved these changes
Aug 6, 2025
src/tests/running.md
Outdated
| @@ -342,14 +342,35 @@ coordinate running tests (see [src/bootstrap/src/core/build_steps/test.rs]). | |||
| > **TODO** | |||
| > | |||
| > - Is there any support for using an iOS emulator? | |||
| > - It's also unclear to me how the wasm or asm.js tests are run. | |||
| > - It's also unclear to me how the asm.js tests are run. | |||
There was a problem hiding this comment.
Suggestion: yet this, asm.js was removed an eternity ago since the asmjs target got yeeted 😆
src/tests/running.md
Outdated
Comment on lines
358
to
360
| Follow the install instructions from the [wasi sdk repository] to get a sysroot on your computer. | ||
| Some cmake commands that take a while and give a lot of very concerning c++ warnings... | ||
| Then, in `bootstrap.toml`, point to the sysroot like so: |
There was a problem hiding this comment.
Suggestion: also note that you need a WASI SDK satisifying the minimum version required by the wasm32-wasip1 target support page, i.e. https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-wasip1.md#building-the-target.
rustbot
removed
the
S-waiting-on-review
|
@jdonszelmann nice that you used sembr |
|
Always, though I didn't know it was named this hehe ❤️ |
|
I wrote too much papers in latex to consider anything else..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jieyouxu
I used slightly playful language which I'm aware of, but I don't think it should matter that much for the devguide. Decided not to remove the TODO comment entirely since I don't know how much of it these instructions resolve.