Skip to content

Links to htmldocck/@has/@matches for searchability #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Links to htmldocck/@has/@matches for searchability #958

merged 1 commit into from
Nov 12, 2020

Conversation

poliorcetics
Copy link
Contributor

Zulip discussion for context

This adds some links to htmldocck.py and the @has/@matches attributes to help with searchability in the dev guide.

@jyn514 jyn514 self-assigned this Nov 11, 2020
@jyn514 jyn514 added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 11, 2020
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed

@jyn514 jyn514 added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Nov 11, 2020
@poliorcetics
Copy link
Contributor Author

Done, I squashed the second commit into the first since its so small and the first was not useful anymore.

@poliorcetics

This comment has been minimized.

@rustbot rustbot added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels Nov 11, 2020
@jyn514 jyn514 merged commit f36f645 into rust-lang:master Nov 12, 2020
@poliorcetics poliorcetics deleted the rustdoc-link-command branch November 12, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants