intrinsic-test: Adding x86 behavioural testing.
#1894
Draft
+810
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
7
to
8
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct X86IntrinsicType(pub IntrinsicType); |
There was a problem hiding this comment.
@folkertdev as per our discussion in #1884 (comment), would it make sense to add architecture-specific elements here?
Notes: 1. chunk_info has been moved to `common/mod.rs` since it will be needed for all architectures
madhav-madhusoodanan
force-pushed
the
intrinsic-test-x86-addition
branch
from
cbe9081 to
246fef9
Compare
madhav-madhusoodanan
force-pushed
the
intrinsic-test-x86-addition
branch
from
41db5a8 to
5fc0f3b
Compare
folkertdev
reviewed
Aug 5, 2025
Comment on lines
+56
to
+58
| fn build_c_file(&self) -> bool { | ||
| let c_target = "aarch64"; | ||
| let platform_headers = &["arm_neon.h", "arm_acle.h", "arm_fp16.h"]; |
There was a problem hiding this comment.
is this just a direct copy right now? otherwise why does arm show up here?
Comment on lines
+199
to
+210
| match str::parse::<u32>(etype_processed.as_str()) { | ||
| Ok(value) => data.bit_len = Some(value), | ||
| Err(_) => { | ||
| data.bit_len = match data.kind() { | ||
| TypeKind::Char(_) => Some(8), | ||
| TypeKind::BFloat => Some(16), | ||
| TypeKind::Int(_) => Some(32), | ||
| TypeKind::Float => Some(32), | ||
| _ => None, | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
why are only some type kinds covered here? Maybe this could be a method on TypeKind?
Comment on lines
+9
to
+29
| .add_arch_flags(vec![ | ||
| "avx", | ||
| "avx2", | ||
| "avx512f", | ||
| "avx512cd", | ||
| "avx512dq", | ||
| "avx512vl", | ||
| "avx512bw", | ||
| "avx512bf16", | ||
| "avx512bitalg", | ||
| "lzcnt", | ||
| "popcnt", | ||
| "adx", | ||
| "aes", | ||
| ]) | ||
| .set_compiler(cpp_compiler) | ||
| .set_target(&config.target) | ||
| .set_opt_level("2") | ||
| .set_cxx_toolchain_dir(config.cxx_toolchain_dir.as_deref()) | ||
| .set_project_root("c_programs") | ||
| .add_extra_flags(vec!["-ffp-contract=off", "-Wno-narrowing"]); |
There was a problem hiding this comment.
#1896 just merged, so now the vec! calls here can be dropped (just pass an array)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a redo of PR #1814, since a lot of details have changed with PRs #1863, #1862, #1861, #1852.
r? @folkertdev
cc: @Amanieu