Skip to content

intrinsic-test: Cleaning the IntrinsicType struct and related functionalities #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

madhav-madhusoodanan
Copy link
Contributor

@madhav-madhusoodanan madhav-madhusoodanan commented Aug 5, 2025

Summary

  1. Changed from IntrinsicType::target to ArmIntrinsicType::target since its usage is highly architecture-dependent.
  2. Changed the structure of ArmIntrinsicType from
pub struct ArmIntrinsicType(pub IntrinsicType);

to

pub struct ArmIntrinsicType {
    pub data: IntrinsicType,
    pub target: String,
}
  1. Moved arm::chunk_info to common::chunk_info.
  2. Removed from_c in IntrinsicTypeDefinition trait.

r? @folkertdev
cc: @Amanieu

Changes: 1. Removed `from_c` from the IntrinsicType definition. 2. Moved
the `from_c` arm-specific definition to an ArmIntrinsicType-specific
impl block
@folkertdev folkertdev added this pull request to the merge queue Aug 5, 2025
Merged via the queue into rust-lang:master with commit 071373d Aug 5, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants