Undefined index during merge #621
Conversation
dekker-m
commented
May 21, 2018
dekker-m
commented
- Fixed undefined index in merge() method (See Undefined index during code coverage merge #619 )
- Removed code from merge() to yield correct merge results
- Added test case for merging coverage files in reverse order (to prevent undefined index again)
- Changed merge test cases to assert against the expected output from a single coverage run, instead of the currently "bugged" result.
* Removed code from merge() to yield correct merge results * Added test case for merging coverage files in reverse order (to prevent undefined index again) * Changed merge test cases to assert against the expected output from a single coverage run, instead of the currently "bugged" result.
|
I've just run this against our projects, but the results still don't seem to be correctly. The test cases for php-code-coverage don't seem to cover all edge cases well. I'll check if I can find some of those edge cases within our test data/projects. |
|
I've been debugging some more tonight. The difference between running test suits in single run or spread over multiple processes are minimal now (< 0.3%). However, the results still don't seem to exactly match. Dead code is merged correctly, multiple test cases covering the same line merge correctly, however there still seems to be an issue with not executed test lines and lines which will never be executed. I'll let you know once I've figured out some more. |
|
The latest commit should do the trick, the last few difference were caused by a setting in Codeception |
