Skip to content

Enhancement: Run builds with Xdebug 3 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

localheinz
Copy link
Contributor

This PR

  • runs builds with Xdebug 3

Follows #769 (comment).

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #772 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #772      +/-   ##
============================================
- Coverage     82.21%   82.18%   -0.03%     
  Complexity      978      978              
============================================
  Files            58       58              
  Lines          2963     2964       +1     
============================================
  Hits           2436     2436              
- Misses          527      528       +1     
Impacted Files Coverage Δ Complexity Δ
src/Driver/Xdebug2Driver.php 36.58% <0.00%> (-0.92%) 16.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4801f3c...77efb0e. Read the comment docs.

@localheinz localheinz marked this pull request as ready for review June 18, 2020 20:53
@localheinz localheinz force-pushed the feature/xdebug branch 2 times, most recently from e62725a to f00c23b Compare June 18, 2020 20:56
@sebastianbergmann
Copy link
Owner

I am sorry to say that this does not work:

  • 7.3, pcov, lowest: PHP 7.3.19-1+ubuntu18.04.1+deb.sury.org+1 with PCOV 1.0.6
  • 7.3, pcov, highest: PHP 7.3.19-1+ubuntu18.04.1+deb.sury.org+1 with PCOV 1.0.6
  • 7.3, xdebug2, lowest: PHP 7.3.19-1+ubuntu18.04.1+deb.sury.org+1 with Xdebug 2.9.6
  • 7.3, xdebug2, highest: PHP 7.3.19-1+ubuntu18.04.1+deb.sury.org+1 with Xdebug 2.9.6
  • 7.3, xdebug3, lowest: PHP 7.3.19-1+ubuntu18.04.1+deb.sury.org+1 and No code coverage driver available -> Xdebug is not loaded, we are not testing what we want
  • 7.3, xdebug3, highest: PHP 7.3.19-1+ubuntu18.04.1+deb.sury.org+1 and No code coverage driver available -> Xdebug is not loaded, we are not testing what we want
  • 7.4, pcov, lowest: PHP 7.4.7 with PCOV 1.0.6
  • 7.4, pcov, highest: PHP 7.4.7 with PCOV 1.0.6
  • 7.4, xdebug2 lowest: PHP 7.4.7 with Xdebug 2.9.6
  • 7.4, xdebug2 highest: PHP 7.4.7 with Xdebug 2.9.6
  • 7.4, xdebug3 lowest: PHP 7.4.7 and No code coverage driver available -> Xdebug is not loaded, we are not testing what we want
  • 7.4, xdebug3 highest: PHP 7.4.7 and No code coverage driver available -> Xdebug is not loaded, we are not testing what we want
  • 8.0, pcov, lowest: PHP 8.0.0-dev with PCOV 1.0.6
  • 8.0, pcov, highest: PHP 8.0.0-dev with PCOV 1.0.6
  • 8.0, xdebug2 lowest: PHP 8.0.0-dev with PCOV 1.0.6 -> Xdebug is not loaded, we are not testing what we want
  • 8.0, xdebug2 highest: PHP 8.0.0-dev with PCOV 1.0.6 -> Xdebug is not loaded, we are not testing what we want
  • 8.0, xdebug3 lowest: PHP 8.0.0-dev and No code coverage driver available -> Xdebug is not loaded, we are not testing what we want
  • 8.0, xdebug3 highest: PHP 8.0.0-dev and No code coverage driver available -> Xdebug is not loaded, we are not testing what we want

Xdebug 3 is not installed for/used with PHP 7.3, PHP 7.4, and PHP 8. Xdebug 2 is not installed for/used with PHP 8.

@sebastianbergmann
Copy link
Owner

Xdebug 2 is not installed for/used with PHP 8.

We should not even try to use Xdebug 2 on PHP 8 as Xdebug 2 will not support PHP 8.

@localheinz localheinz force-pushed the feature/xdebug branch 14 times, most recently from 7971004 to ab7e2b9 Compare June 19, 2020 07:00
@localheinz localheinz marked this pull request as draft June 19, 2020 07:00
@localheinz localheinz force-pushed the feature/xdebug branch 3 times, most recently from 52bc8e6 to 345a576 Compare June 19, 2020 07:07
@localheinz
Copy link
Contributor Author

@sebastianbergmann

This should work now. Looks like Xdebug 3 is detected as PCOV:

Screen Shot 2020-06-19 at 09 11 40

@localheinz localheinz marked this pull request as ready for review June 21, 2020 09:58
@localheinz
Copy link
Contributor Author

@sebastianbergmann

Thanks to @shivammathur, this works now as expected!

👍

@sebastianbergmann sebastianbergmann merged commit 559de68 into sebastianbergmann:master Jun 21, 2020
@localheinz localheinz deleted the feature/xdebug branch June 21, 2020 14:30
@localheinz
Copy link
Contributor Author

Thank you, @sebastianbergmann and @shivammathur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants