Skip to content

Conversation

james-pre
Copy link

PR Checklist

Overview

This PR removes dependence on fast-glob by switching to the built-in fs.globSync function included as of Node v22, which is current active LTS and minimum used by typescript-eslint.

Footnotes

  1. There has been a lot of discussion in the issue, and it hasn't been fully accepted, so I'm creating it as a draft.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @james-pre!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3532229
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68b0c4ceed37cb000899bb01
😎 Deploy Preview https://deploy-preview-11539--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@james-pre james-pre marked this pull request as draft August 28, 2025 20:55
Copy link

nx-cloud bot commented Aug 28, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 3532229

Command Status Duration Result
nx test typescript-estree ❌ Failed 31s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 5s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
Additional runs (14) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-28 21:13:47 UTC

@james-pre james-pre changed the title fix(typescript-estree): Replace fast-glob with builtin fs.globSync fix(typescript-estree): Replace fast-glob with builtin globSync Aug 28, 2025
@james-pre james-pre changed the title fix(typescript-estree): Replace fast-glob with builtin globSync fix(typescript-estree): replace fast-glob with builtin globSync Aug 28, 2025
@kirkwaiblinger
Copy link
Member

We currently support node 18 still...

@james-pre
Copy link
Author

Node 18 is end-of-life and deprecated. Plus, typescript-estree already ships with @types/node 22, which I figured meant using node 22 APIs would be okay. If not, perhaps a downgrade to @types/node 18 is needed.

@kirkwaiblinger
Copy link
Member

@james-pre

Node 18 is end-of-life and deprecated.

Yes but it would be a breaking change to use APIs not available in node 18. Support for EOL versions of node will obviously be dropped in the next major version though.

Plus, typescript-estree already ships with @types/node 22, which I figured meant using node 22 APIs would be okay. If not, perhaps a downgrade to @types/node 18 is needed.

No worries! If you have suggestions about how to improve the developer experience of this repo (such as by staying on older versions of node types) feel free to file an issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: replace fast-glob with tinyglobby
2 participants