-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(typescript-estree): replace fast-glob with builtin globSync #11539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @james-pre! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Command | Status | Duration | Result |
---|---|---|---|
nx test typescript-estree |
❌ Failed | 31s | View ↗ |
nx test eslint-plugin --coverage=false |
✅ Succeeded | 5m 5s | View ↗ |
nx run-many -t lint |
✅ Succeeded | 3m 17s | View ↗ |
nx run-many -t typecheck |
✅ Succeeded | 2m | View ↗ |
nx test typescript-estree --coverage=false |
✅ Succeeded | 21s | View ↗ |
nx run types:build |
✅ Succeeded | 5s | View ↗ |
nx test eslint-plugin-internal --coverage=false |
✅ Succeeded | 11s | View ↗ |
nx run integration-tests:test |
✅ Succeeded | 5s | View ↗ |
Additional runs (14) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-08-28 21:13:47
UTC
fs.globSync
We currently support node 18 still... |
Node 18 is end-of-life and deprecated. Plus, typescript-estree already ships with @types/node 22, which I figured meant using node 22 APIs would be okay. If not, perhaps a downgrade to @types/node 18 is needed. |
Yes but it would be a breaking change to use APIs not available in node 18. Support for EOL versions of node will obviously be dropped in the next major version though.
No worries! If you have suggestions about how to improve the developer experience of this repo (such as by staying on older versions of node types) feel free to file an issue 👍 |
PR Checklist
fast-glob
withtinyglobby
#10533Overview
This PR removes dependence on
fast-glob
by switching to the built-infs.globSync
function included as of Node v22, which is current active LTS and minimum used by typescript-eslint.Footnotes
There has been a lot of discussion in the issue, and it hasn't been fully accepted, so I'm creating it as a draft. ↩