chore: introduce @eslint/markdown and eslint-plugin-markdown-preferences
#2913
Conversation
|
| import globals from 'globals' | ||
| import eslintPluginEslintPlugin from 'eslint-plugin-eslint-plugin/configs/all' | ||
| import eslintPluginJsonc from 'eslint-plugin-jsonc' | ||
| import eslintPluginNodeDependencies from 'eslint-plugin-node-dependencies' | ||
| import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended' | ||
| import eslintPluginUnicorn from 'eslint-plugin-unicorn' | ||
| import eslintMarkdown from '@eslint/markdown' | ||
| import markdownPreferences from 'eslint-plugin-markdown-preferences' |
There was a problem hiding this comment.
Please rename this variable to eslintPluginMarkdownPreferences for consistency, even if it's long.
| export default typegen([ | ||
| { | ||
| ignores: [ | ||
| '.nyc_output', | ||
| 'coverage', | ||
| 'node_modules', | ||
| '.changeset/**/*.md', |
There was a problem hiding this comment.
Why are those files ignored completely?
| /** A list of expression nodes to verify */ | ||
| const expressions = | ||
| expression.type === 'TemplateLiteral' | ||
| ? expression.expressions | ||
| : expression.type === 'ConditionalExpression' | ||
| ? [expression.test, expression.consequent, expression.alternate] | ||
| : expression.type === 'Identifier' | ||
| ? [expression] | ||
| : [] | ||
| /** @type {Expression[]} A list of expression nodes to verify */ | ||
| const expressions = [] | ||
| switch (expression.type) { | ||
| case 'TemplateLiteral': { | ||
| expressions.push(...expression.expressions) | ||
| break | ||
| } | ||
| case 'ConditionalExpression': { | ||
| expressions.push( | ||
| expression.test, | ||
| expression.consequent, | ||
| expression.alternate | ||
| ) | ||
| break | ||
| } | ||
| case 'Identifier': { | ||
| expressions.push(expression) | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
This change is unrelated, right? It looks like a good change, so no need to revert it or anything, I just stumbled a bit over it.
| - [vue/singleline-html-element-content-newline](./singleline-html-element-content-newline.md) | ||
| - [no-multiple-empty-lines](https://eslint.org/docs/rules/no-multiple-empty-lines) | ||
| - [no-multiple-empty-lines] | ||
|
|
||
| [no-multiple-empty-lines]: https://eslint.org/docs/rules/no-multiple-empty-lines |
There was a problem hiding this comment.
Why extract one of them but not both? I think extracting only really makes sense when the link is reused multiple times, so here, I'd keep it inlined.
| - [vue-async-computed](https://github.com/foxbenjaminfox/vue-async-computed) | ||
| - [vue-async-computed] | ||
|
|
||
| [vue-async-computed]: https://github.com/foxbenjaminfox/vue-async-computed |
There was a problem hiding this comment.
Again, why extract the link target here?
This PR introduces
@eslint/markdownandeslint-plugin-markdown-preferencesto the repository.We prefer to have links in rule names in release notes and changelog, and this PR will allow the
markdown-preferences/prefer-linked-wordsrule to automatically detect and fix that.https://ota-meshi.github.io/eslint-plugin-markdown-preferences/rules/prefer-linked-words.html
After merging this PR, I believe the
changeset:versionscript should automatically include the link without having to include it in the changeset file.