v3.1.2: Fix guidance on headers and RFC6570 percent-encoding #4819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After much debate and research, we agreed that percent-encoding was never meant to be applied to headers. Exactly how to handle RFC6570 and cookie parameters remains TBD. For now, this preserves (but streamlines) the existing guidance for cookies.
handrews
added
clarification
|
@ralfhandl the "no spaces inside code span element" is causing a linting failure even though the space is there intentionally. Is it possible to disable the rule for this particular use? Or would it need to be disabled for the whole document? |
|
@ralfhandl I can't even get it to turn off locally. I reworded the sentence- I dislike this option but I care more about getting this merged than blocking on linter pickiness. |
3 tasks
earth2marsh
previously approved these changes
Aug 3, 2025
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Since this is just correcting incorrect guidance rather than changing the actual behavior, it is suitable for a patch release. I will port it to 3.2, where it will be paired with a fix to
allowReservedthat is not needed in 3.1.2, once merged.Fixes part of #4798.
After much debate and research, we agreed that percent-encoding was never meant to be applied to headers.
Exactly how to handle RFC6570 with cookie parameters remains TBD. For now, this preserves (but streamlines) the existing guidance for cookies.