Skip to content

[sanitizer_common] Disable SanitizerCommon lsan tests on Apple arm64 #151929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanBlackwell
Copy link
Contributor

There is an issue tracking lsan incompatibility on these platforms: #131678. Many of these tests are currently failing and creating CI noise.

rdar://157252316

There is an issue tracking lsan incompatibility on these platforms: llvm#131678. Many of these tests are currently failing and creating CI noise.
@llvmbot
Copy link
Member

llvmbot commented Aug 4, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Dan Blackwell (DanBlackwell)

Changes

There is an issue tracking lsan incompatibility on these platforms: #131678. Many of these tests are currently failing and creating CI noise.

rdar://157252316


Full diff: https://github.com/llvm/llvm-project/pull/151929.diff

1 Files Affected:

  • (modified) compiler-rt/test/sanitizer_common/CMakeLists.txt (+1-1)
diff --git a/compiler-rt/test/sanitizer_common/CMakeLists.txt b/compiler-rt/test/sanitizer_common/CMakeLists.txt
index 615666676f57a..e455092a98875 100644
--- a/compiler-rt/test/sanitizer_common/CMakeLists.txt
+++ b/compiler-rt/test/sanitizer_common/CMakeLists.txt
@@ -91,7 +91,7 @@ foreach(tool ${SUPPORTED_TOOLS})
     # so don't run the tests by default.
     if (NOT (CMAKE_SYSTEM_NAME MATCHES "Darwin" AND
              ${tool} STREQUAL "lsan" AND
-             ${arch} STREQUAL "i386"))
+             (${arch} STREQUAL "i386" OR ${arch} MATCHES "arm64")))
       list(APPEND SANITIZER_COMMON_TESTSUITES
            ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
     endif()

@yln yln self-requested a review August 4, 2025 17:22
@@ -91,7 +91,7 @@ foreach(tool ${SUPPORTED_TOOLS})
# so don't run the tests by default.
if (NOT (CMAKE_SYSTEM_NAME MATCHES "Darwin" AND
${tool} STREQUAL "lsan" AND
${arch} STREQUAL "i386"))
(${arch} STREQUAL "i386" OR ${arch} MATCHES "arm64")))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add comment referencing the issue you mentioned: #131678

I think this would be useful in both directions:

  • Folks reading this code can lookup the explanation for disablement
  • If the issue is fixed, having a breadcrumb here increases the chance that these tests are re-enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants