Skip to content

[sanitizer_common] Disable SanitizerCommon lsan tests on Apple arm64 #151929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[sanitizer_common] Disable SanitizerCommon lsan tests on Apple arm64 #151929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler-rt/test/sanitizer_common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,10 @@ foreach(tool ${SUPPORTED_TOOLS})
${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg.py)
# FIXME(dliew): LSan i386 on Darwin is completely broken right now.
# so don't run the tests by default.
# Tests fail on arm64, see https://github.com/llvm/llvm-project/issues/131678
if (NOT (CMAKE_SYSTEM_NAME MATCHES "Darwin" AND
${tool} STREQUAL "lsan" AND
${arch} STREQUAL "i386"))
(${arch} STREQUAL "i386" OR ${arch} MATCHES "arm64")))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add comment referencing the issue you mentioned: #131678

I think this would be useful in both directions:

  • Folks reading this code can lookup the explanation for disablement
  • If the issue is fixed, having a breadcrumb here increases the chance that these tests are re-enabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done!

list(APPEND SANITIZER_COMMON_TESTSUITES
${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
endif()
Expand Down
Loading