-
Notifications
You must be signed in to change notification settings - Fork 14.7k
[libc][Github] Remove ccache variant logic #152042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
boomanaiden154
wants to merge
1
commit into
llvm:main
Choose a base branch
from
boomanaiden154:libc-fix-sccache-280
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs/ccache-action#279 has now been resolved, so we can use sccache for the arm tests too and do not need to differentiate between platforms.
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) Changeshendrikmuhs/ccache-action#279 has now been resolved, so we can use sccache for the arm tests too and do not need to differentiate between platforms. Full diff: https://github.com/llvm/llvm-project/pull/152042.diff 2 Files Affected:
diff --git a/.github/workflows/libc-fullbuild-tests.yml b/.github/workflows/libc-fullbuild-tests.yml
index fe3dc50f6b9fc..df447246ee5f2 100644
--- a/.github/workflows/libc-fullbuild-tests.yml
+++ b/.github/workflows/libc-fullbuild-tests.yml
@@ -20,36 +20,30 @@ jobs:
include:
- os: ubuntu-24.04
build_type: Debug
- ccache-variant: sccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: Release
- ccache-variant: sccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: MinSizeRel
- ccache-variant: sccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-linux-llvm
include_scudo: ON
- # TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
build_type: Debug
- ccache-variant: ccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: aarch64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: Debug
- ccache-variant: ccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-uefi-llvm
@@ -71,7 +65,7 @@ jobs:
with:
max-size: 1G
key: libc_fullbuild_${{ matrix.c_compiler }}
- variant: ${{ matrix.ccache-variant }}
+ variant: sccache
# Notice:
# - MPFR is required by some of the mathlib tests.
@@ -112,8 +106,8 @@ jobs:
-DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} \
-DCMAKE_C_COMPILER=${{ matrix.c_compiler }} \
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
- -DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }} \
- -DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }} \
+ -DCMAKE_C_COMPILER_LAUNCHER=sccache \
+ -DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
-DCMAKE_INSTALL_PREFIX=${{ steps.strings.outputs.build-install-dir }} \
-DLLVM_RUNTIME_TARGETS=${{ matrix.target }} \
-DLLVM_ENABLE_RUNTIMES="$RUNTIMES" \
diff --git a/.github/workflows/libc-overlay-tests.yml b/.github/workflows/libc-overlay-tests.yml
index f001daae030a3..e3dc4166aa26c 100644
--- a/.github/workflows/libc-overlay-tests.yml
+++ b/.github/workflows/libc-overlay-tests.yml
@@ -20,28 +20,22 @@ jobs:
include:
# TODO: add linux gcc when it is fixed
- os: ubuntu-24.04
- ccache-variant: sccache
compiler:
c_compiler: clang
cpp_compiler: clang++
- # TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
- ccache-variant: ccache
compiler:
c_compiler: clang
cpp_compiler: clang++
- os: windows-2022
- ccache-variant: sccache
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: windows-2025
- ccache-variant: sccache
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: macos-14
- ccache-variant: sccache
compiler:
c_compiler: clang
cpp_compiler: clang++
@@ -61,7 +55,7 @@ jobs:
with:
max-size: 1G
key: libc_overlay_build_${{ matrix.os }}_${{ matrix.compiler.c_compiler }}
- variant: ${{ matrix.ccache-variant }}
+ variant: sccache
# MPFR is required by some of the mathlib tests.
- name: Prepare dependencies (Ubuntu)
@@ -97,8 +91,8 @@ jobs:
-DCMAKE_CXX_COMPILER=${{ matrix.compiler.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.compiler.c_compiler }}
-DCMAKE_BUILD_TYPE=Debug
- -DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
- -DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
+ -DCMAKE_C_COMPILER_LAUNCHER=sccache
+ -DCMAKE_CXX_COMPILER_LAUNCHER=sccache
-DCMAKE_POLICY_DEFAULT_CMP0141=NEW
-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded
-DLLVM_ENABLE_RUNTIMES=libc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hendrikmuhs/ccache-action#279 has now been resolved, so we can use sccache for the arm tests too and do not need to differentiate between platforms.