Skip to content

[libc][Github] Remove ccache variant logic #152042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions .github/workflows/libc-fullbuild-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,36 +20,30 @@ jobs:
include:
- os: ubuntu-24.04
build_type: Debug
ccache-variant: sccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: Release
ccache-variant: sccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: MinSizeRel
ccache-variant: sccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-linux-llvm
include_scudo: ON
# TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
build_type: Debug
ccache-variant: ccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: aarch64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: Debug
ccache-variant: ccache
c_compiler: clang-20
cpp_compiler: clang++-20
target: x86_64-unknown-uefi-llvm
Expand All @@ -71,7 +65,7 @@ jobs:
with:
max-size: 1G
key: libc_fullbuild_${{ matrix.c_compiler }}
variant: ${{ matrix.ccache-variant }}
variant: sccache

# Notice:
# - MPFR is required by some of the mathlib tests.
Expand Down Expand Up @@ -112,8 +106,8 @@ jobs:
-DCMAKE_CXX_COMPILER=${{ matrix.cpp_compiler }} \
-DCMAKE_C_COMPILER=${{ matrix.c_compiler }} \
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \
-DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }} \
-DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }} \
-DCMAKE_C_COMPILER_LAUNCHER=sccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
-DCMAKE_INSTALL_PREFIX=${{ steps.strings.outputs.build-install-dir }} \
-DLLVM_RUNTIME_TARGETS=${{ matrix.target }} \
-DLLVM_ENABLE_RUNTIMES="$RUNTIMES" \
Expand Down
12 changes: 3 additions & 9 deletions .github/workflows/libc-overlay-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,28 +20,22 @@ jobs:
include:
# TODO: add linux gcc when it is fixed
- os: ubuntu-24.04
ccache-variant: sccache
compiler:
c_compiler: clang
cpp_compiler: clang++
# TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
ccache-variant: ccache
compiler:
c_compiler: clang
cpp_compiler: clang++
- os: windows-2022
ccache-variant: sccache
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: windows-2025
ccache-variant: sccache
compiler:
c_compiler: clang-cl
cpp_compiler: clang-cl
- os: macos-14
ccache-variant: sccache
compiler:
c_compiler: clang
cpp_compiler: clang++
Expand All @@ -61,7 +55,7 @@ jobs:
with:
max-size: 1G
key: libc_overlay_build_${{ matrix.os }}_${{ matrix.compiler.c_compiler }}
variant: ${{ matrix.ccache-variant }}
variant: sccache

# MPFR is required by some of the mathlib tests.
- name: Prepare dependencies (Ubuntu)
Expand Down Expand Up @@ -97,8 +91,8 @@ jobs:
-DCMAKE_CXX_COMPILER=${{ matrix.compiler.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.compiler.c_compiler }}
-DCMAKE_BUILD_TYPE=Debug
-DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_C_COMPILER_LAUNCHER=sccache
-DCMAKE_CXX_COMPILER_LAUNCHER=sccache
-DCMAKE_POLICY_DEFAULT_CMP0141=NEW
-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT=Embedded
-DLLVM_ENABLE_RUNTIMES=libc
Expand Down
Loading