[mlir][spirv] Change Spirv.GlobalVariableOp builtin -> built_in #152148
Conversation
GlobalVarialeOp describes that built_in specifies SPIR-V BuiltIn
decoration associated with the op. The attribute was defined as builtin
in the tablegen (no uderscore). This was causing correct
GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be
saved as a new attribute making it impossible to access the built_in
attribute through getBuiltinAttr.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-mlir-spirv Author: None (moscickimilosz) ChangesGlobalVariableOp describes that built_in specifies SPIR-V BuiltIn decoration associated with the op. The attribute was defined as builtin in the tablegen (no uderscore). This was causing correct GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be saved as a new attribute making it impossible to access the built_in attribute through getBuiltinAttr. Full diff: https://github.com/llvm/llvm-project/pull/152148.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
index 7986025d6ca31..3bd3510fec8f3 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
@@ -451,7 +451,7 @@ def SPIRV_GlobalVariableOp : SPIRV_Op<"GlobalVariable", [InModuleScope, Symbol]>
OptionalAttr<I32Attr>:$___location,
OptionalAttr<I32Attr>:$binding,
OptionalAttr<I32Attr>:$descriptor_set,
- OptionalAttr<StrAttr>:$builtin,
+ OptionalAttr<StrAttr>:$built_in,
OptionalAttr<SPIRV_LinkageAttributesAttr>:$linkage_attributes
);
|
|
@llvm/pr-subscribers-mlir Author: None (moscickimilosz) ChangesGlobalVariableOp describes that built_in specifies SPIR-V BuiltIn decoration associated with the op. The attribute was defined as builtin in the tablegen (no uderscore). This was causing correct GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be saved as a new attribute making it impossible to access the built_in attribute through getBuiltinAttr. Full diff: https://github.com/llvm/llvm-project/pull/152148.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
index 7986025d6ca31..3bd3510fec8f3 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
@@ -451,7 +451,7 @@ def SPIRV_GlobalVariableOp : SPIRV_Op<"GlobalVariable", [InModuleScope, Symbol]>
OptionalAttr<I32Attr>:$___location,
OptionalAttr<I32Attr>:$binding,
OptionalAttr<I32Attr>:$descriptor_set,
- OptionalAttr<StrAttr>:$builtin,
+ OptionalAttr<StrAttr>:$built_in,
OptionalAttr<SPIRV_LinkageAttributesAttr>:$linkage_attributes
);
|
|
@moscickimilosz Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
GlobalVariableOp describes that built_in specifies SPIR-V BuiltIn decoration associated with the op. The attribute was defined as builtin in the tablegen (no uderscore). This was causing correct GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be saved as a new attribute making it impossible to access the built_in attribute through getBuiltinAttr.