Skip to content

Add InterpCx::project_fields #144890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add InterpCx::project_fields #144890

wants to merge 2 commits into from
+44 −33

Conversation

WaffleLapkin
Copy link
Member

I was hoping for a much bigger improvement and this is lukewarm at best ^^'

Still, I think this makes sense.

@WaffleLapkin
small refactor of InterpResult
e3ed3e0 
- don't need type alias to default type argument
- `Residual` impl allows to use more std APIs (like `<[T; N]>::try_map`)
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
@WaffleLapkin WaffleLapkin changed the title Add InterpCx::project_field Add InterpCx::project_fields Aug 4, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the project_fields branch 2 times, most recently from 15caa11 to f87bd48 Compare August 4, 2025 08:41
@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed Aug 4, 2025
View reviewed changes
compiler/rustc_middle/src/mir/interpret/error.rs
res: Result<T, InterpErrorInfo<'tcx>>,
guard: Guard,
}

// Type alias to be able to set a default type argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:thonk:

@lcnr
Copy link
Contributor

lcnr commented Aug 4, 2025

r? lcnr

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 4, 2025

📌 Commit cf7b674 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WaffleLapkin @rustbot @rust-log-analyzer @lcnr @bors @nnethercote