Skip to content

Use an ugly name to help catch field projection #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scottmcm
Copy link
Member

Something's happening, based on rust-lang/rust#144621, so go further than before by removing the visibility from the field and having definitions use a from_array method instead where needed.

This is draft because it's absolutely not going to work first try, but I'd like to borrow CI for fixing.

@scottmcm
Copy link
Member Author

Oh, the arm generator is completely different from when I was last here. I have no idea how to add the ::from_array calls...

@folkertdev
Copy link
Contributor

I fixed those here e3ba06b, you can cherry-pick + squash that if you think that looks good.

@folkertdev folkertdev self-assigned this Jul 29, 2025
@scottmcm
Copy link
Member Author

Oh, no wonder I couldn't find it in the Expression stuff 🤦 Thanks for putting that together!

That said, it looks like the problem wasn't in here after all -- it was just a different thing that failed for all SIMD. So I'm going to close this and not do the churn of updating everything, unless people feel that this would be better (in avoiding accidentally adding projections in future) enough to actually go through with doing it everywhere. Thoughts welcome.

@scottmcm scottmcm closed this Jul 30, 2025
@scottmcm
Copy link
Member Author

Actually, wait, I can do this slow-stepped: add from_array, start using it in places, but not insist that everything move over all at once. That's probably worth doing, at least.

@scottmcm scottmcm reopened this Jul 30, 2025
@scottmcm scottmcm force-pushed the no-simd-projection branch from 84e1f0d to d8453f2 Compare July 30, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants